Bugfix/training crash when viewer refreshes #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughes036
reviewed
Feb 23, 2024
|
I changed the base branch- the diff is now correct (only one method was changed, all the other changes was in the previous PR for loading images via. napari layers. |
saeliddp
reviewed
Feb 26, 2024
saeliddp
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Training runs crash at the end when images are loaded into napari. This causes
PredictionView'sFileInputWidgetto refresh its layer list, and since that image has no channels it crashes the plugin.This change makes it so that we ignore images generated by Training when the layer list is refreshed. Working on a follow up fix which will make it so that this layer list only refreshes when we are focused on the Prediction tab.