Skip to content

Commit

Permalink
comments for failing tests, removing unused variable in tests
Browse files Browse the repository at this point in the history
  • Loading branch information
yrkim98 committed Jan 19, 2024
1 parent 5c731a8 commit ca74a82
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ def test_get_model_checkpoints_no_experiment_name() -> None:
cyto_dl_home_path=Path(__file__).parent / "cyto_dl_home",
user_experiments_path=user_experiments_path,
)
expected = user_experiments_path / "foo" / "checkpoints" / "bar"
model = ExperimentsModel(config)

with pytest.raises(ValueError):
Expand All @@ -77,7 +76,6 @@ def test_get_model_checkpoints_no_checkpoint() -> None:
cyto_dl_home_path=Path(__file__).parent / "cyto_dl_home",
user_experiments_path=user_experiments_path,
)
expected = user_experiments_path / "foo" / "checkpoints" / "bar"
model = ExperimentsModel(config)

with pytest.raises(ValueError):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ def test_build_overrides_experiment_none() -> None:
prediction_model.set_image_input_channel_index(3)

# act/assert
# Experiment name is None, so build_overrides should throw a ValueError
with pytest.raises(ValueError):
overrides: Dict[
str, Union[str, int, float, bool]
Expand Down Expand Up @@ -214,6 +215,7 @@ def test_build_overrides_checkpoint_none() -> None:
prediction_model.set_image_input_channel_index(3)

# act/assert
# Checkpoint is None, so build_overrides should throw a ValueError
with pytest.raises(ValueError):
overrides: Dict[
str, Union[str, int, float, bool]
Expand Down

0 comments on commit ca74a82

Please sign in to comment.