-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It's possible to hover over the very edge of menu items in settings and you trigger the hover but you can’t click it #395
Comments
https://github.com/voodoo/open-hostedgpt/commit/5079f6f8d7de27da23188303026dfe6ee884add7
First time. I've been doing this AI stuff for a bit. That kinda blew me a way. Tries to get a screenshot of the cursor to show you ... but ... I deployed that in no seconds flat - well done sir :) https://hostedgpt-wyse.onrender.com/settings/assistants/2/edit Is it GOOD? Dunno. Prolly not. It checks a lot of boxes. gpt1.movShould I try to get a pull together? (What kind of test would you use - some sort of screen shot, I guess) |
Ohhh, I see what the issue is and I see how you fixed it! Actually, this is an issue both within the settings and also outside the settings (the normal list of assistants). Your fix works, but I'd like to fix it in a slightly different way just to avoid introducing another inner element. You did the hard part of identifying it and figuring out the root cause, thanks!! I'll tee that up right now that fixes it a bit differently. |
Done! I just merged it in. If you're curious, the root of the issue is that the visual hover background was not on the |
Makes sense. I fiddled around with the div's p and m - and even h if i recall. That ai part was the remarkable part. I'll try to find another issue. Great project. Cheers. |
Oh if you want another one! Out 3 words in your name (dr Joe smith) or (Mary Joe sue) and now your avatar has 3 initials and it overflows the circle. It needs to never be more than two initials. |
Do I need to start an issue? (Great, I need the practice) If I'm not missing the forest for the trees ... def user_initials(name, limit: 2) I added the .cursorrules but I need to take it out. https://github.com/voodoo/open-hostedgpt/commit/afaaed46a4d63fdadf804b0ac3c594063cf7499c "Dr Joe Smith" -> "DJ" Something along those lines? |
You don’t have to create an issue. But do create a PR. You should create a method that takes |
This is the menu item that I mean. Try putting your cursor on the very edge of it and clicking:
![image](https://private-user-images.githubusercontent.com/35061/337872591-d8a5f3cc-97ed-4813-9561-28de2a16c2bc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNTM2NDIsIm5iZiI6MTczOTA1MzM0MiwicGF0aCI6Ii8zNTA2MS8zMzc4NzI1OTEtZDhhNWYzY2MtOTdlZC00ODEzLTk1NjEtMjhkZTJhMTZjMmJjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDIyMjIyMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTljM2U5NzY5NTY1ZTFjMmYxYmZmNWI1NTYzNmZmNzdhNjg1YTMxMTQ2MmMzMTJjMjkyZTMzMmI2YjY5ZTc0MWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ExxYyMUVRKr0PkbodaHW8fJaxRFENN-kUU4LFw0mle0)
This is almost surely because the hover CSS effect is being applied to the container of the a href, and there is likely some internal padding or margin on that. Maybe we can fix this by simply moving the hover effect from the outer container to the a href. Although, that may change the visual size of the hover effect which we don’t want. Probably the better fix is to identify whatever margin or padding is on the container and see if we can change margin > padding or padding > margin, not sure which way we’d need to tweak it. Or maybe we can move that padding/margin from the container into the a href interior item, which would increase it’s clickable size.
The text was updated successfully, but these errors were encountered: