Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FF doesn't restore scroll position #393

Closed
arielsvn opened this issue Oct 15, 2018 · 3 comments · Fixed by #480
Closed

FF doesn't restore scroll position #393

arielsvn opened this issue Oct 15, 2018 · 3 comments · Fixed by #480
Assignees
@arielsvn
Labels
bug Something isn't working

Comments

@arielsvn
Copy link
Contributor

2018-10-15 16 21 17

We fixed this on #126, but it doesn't seem to work with Firefox.
@arielsvn arielsvn added the bug Something isn't working label Oct 15, 2018
@arielsvn arielsvn self-assigned this Oct 15, 2018
@Miserlou
Copy link
Contributor

Literally my biggest pet peeve in the entire world.

@arielsvn arielsvn mentioned this issue Oct 25, 2018
Merged
5 tasks
@arielsvn
Copy link
Contributor Author

arielsvn commented Oct 25, 2018 •
edited
Loading

I tried to fix this on #405, but I'm still unsure why FF doesn't restore scroll position. Some comments on why this is hard here and in this polyfill

Also on react-router docs

@arielsvn arielsvn added next and removed in progress labels Oct 26, 2018
@ghost ghost removed the next label Oct 26, 2018
@arielsvn
Copy link
Contributor Author

closed by mistake, reopening

@arielsvn arielsvn reopened this Oct 29, 2018
@arielsvn arielsvn added the next label Oct 29, 2018
@arielsvn arielsvn added in progress and removed next labels Dec 20, 2018
@arielsvn arielsvn mentioned this issue Dec 20, 2018
Merged
5 tasks
@ghost ghost added review and removed in progress labels Dec 20, 2018
@ghost ghost removed the review label Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arielsvn arielsvn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add delayed-scroll-restoration-polyfill AlexsLemonade/refinebio-frontend
2 participants
@Miserlou @arielsvn