This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
add methods for collapse rnaseq and immunedeconv #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharenza
suggested changes
Dec 2, 2019
|
@komalsrathi @jaclyn-taroni I started to review on the collapsing RNA-Seq methods but had some questions about amount of detail we want to add, especially with data-to-come. I think we may want to wait to review cibersort methods until we review that analysis PR - should we break this up into two PRs? |
2 tasks
|
@komalsrathi : it looks like @jharenza had some comments here. Can you address them? It also looks like you checked "All changes to text follow 'one sentence per line'" but this is not true as @jharenza notes. It's hard to effectively review without that. Please fix this ASAP. |
|
Hi Casey,
I haven’t looked at this after Jo Lynne posted that comment - I may have
checked All changes.. before she posted the comment probably because I dont
know what that means. I’ll fix that when I can and let everybody know once
I have. Thanks.
On Fri, Dec 20, 2019 at 8:34 AM Casey Greene ***@***.***> wrote:
@komalsrathi <https://github.com/komalsrathi> : it looks like @jharenza
<https://github.com/jharenza> had some comments here. Can you address
them?
It also looks like you checked "All changes to text follow 'one sentence
per line'" but this is not true as @jharenza <https://github.com/jharenza>
notes. It's hard to effectively review without that. Please fix this ASAP.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#64?email_source=notifications&email_token=ABVNEJ4W33OOHT22VACB2T3QZTCVBA5CNFSM4JR5HWT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHM5YVQ#issuecomment-567925846>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVNEJZOREBZZYDDHRDQJU3QZTCVBANCNFSM4JR5HWTQ>
.
--
*Komal S Rathi* | Bioinformatics Scientist II, DBHi, The Children's
Hospital of Philadelphia | rathik@email.chop.edu
|
Co-Authored-By: Jo Lynne <jharenza@gmail.com>
Co-Authored-By: Jo Lynne <jharenza@gmail.com>
Co-Authored-By: Jo Lynne <jharenza@gmail.com>
|
@jharenza This is ready to review, whenever you get a chance. Please let me know. Thanks! |
2 tasks
|
@jharenza I believe this is ready for another look now that the analysis PRs have gone in. |
jharenza
approved these changes
Jan 10, 2020
cgreene
pushed a commit
that referenced
this pull request
Jan 13, 2020
This build is based on 7a25ff2. This commit was created by the following Travis CI build and job: https://travis-ci.com/AlexsLemonade/OpenPBTA-manuscript/builds/144219729 https://travis-ci.com/AlexsLemonade/OpenPBTA-manuscript/jobs/275088921 [ci skip] The full commit message that triggered this build is copied below: Merge pull request #64 from komalsrathi/collapse-immunedeconv-methods add methods for collapse rnaseq and immunedeconv
cgreene
pushed a commit
that referenced
this pull request
Jan 13, 2020
This build is based on 7a25ff2. This commit was created by the following Travis CI build and job: https://travis-ci.com/AlexsLemonade/OpenPBTA-manuscript/builds/144219729 https://travis-ci.com/AlexsLemonade/OpenPBTA-manuscript/jobs/275088921 [ci skip] The full commit message that triggered this build is copied below: Merge pull request #64 from komalsrathi/collapse-immunedeconv-methods add methods for collapse rnaseq and immunedeconv
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add methods for collapse rnaseq as per AlexsLemonade/OpenPBTA-analysis#198 (review) and immune deconvolution as per AlexsLemonade/OpenPBTA-analysis#15
Issue
#56
Pull review checklist
The PR will be considered ready for review when all four items have been checked.