This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add folder for notebooks
add gitignore
update output file path handle in get-tcga-capture_kit.py
add boxplot.R
skip the manifest header
add ci for tcga-capture-kit-investigation
Merge branch 'analyses/tcga-capture-kit-investigation' of https://github.com/yuankunzhu/OpenPBTA-analysis into Teja_tmbQC
…vestigation.sh script
Co-Authored-By: jashapiro <josh.shapiro@ccdatalab.org>
…_ewings_foi.tsv for v16
cansavvy
commented
Apr 3, 2020
@@ -68,9 +68,6 @@ cp $FULL_DIRECTORY/independent-specimens*.tsv $SUBSET_DIRECTORY | |||
# all bed files | |||
cp $FULL_DIRECTORY/*.bed $SUBSET_DIRECTORY | |||
|
|||
# the release notes | |||
cp $FULL_DIRECTORY/release-notes.md $SUBSET_DIRECTORY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this is why I was missing files. Because the script failed at this step before and the other files after it did not get copied. I ran everything again just in case.
jaclyn-taroni
approved these changes
Apr 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What scientific question is your analysis addressing?
Setting up the subset files for v16 release so we can test the changes on CircleCI.
What was your approach?
analyses/create-subset-files/create_subset_files.sh
update to v16bash analyses/create-subset-files/create_subset_files.sh
v16-ci
branch.data/testing/release-v16-20200320/
totesting_v16.zip
What GitHub issue does your pull request address?
#657
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
create_subset_files.sh
script noted that there is no release-notes.md file in the v16 data?? Is that forth coming?Are there any steps that I should have taken that are not mentioned here?
If all looks as expected, I will upload the subsetted v16 files so we can begin working on breaking changes, but probably would be good to track down the
release-notes.md
file first.