Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

v15 update for EPN subtyping #592

Merged
merged 6 commits into from
Mar 2, 2020

Conversation

jashapiro
Copy link
Member

Purpose/implementation Section

What scientific question is your analysis addressing?

v15 breaking changes

What was your approach?

replace disease_type_new with integrated_diagnosis.
This resulted in no changes to output files when rerun.

What GitHub issue does your pull request address?

#574

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

@cansavvy cansavvy mentioned this pull request Mar 2, 2020
@cbethell cbethell self-requested a review March 2, 2020 19:18
Copy link
Contributor

@cbethell cbethell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jashapiro jashapiro merged commit 94fbb85 into AlexsLemonade:master Mar 2, 2020
@jashapiro
Copy link
Member Author

Merged before expected CI failure

@jashapiro jashapiro deleted the jashapiro/v15_EPN_updates branch April 11, 2021 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants