This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Update Interaction plots for v15 #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Passed CI with only this module running. |
cbethell
approved these changes
Mar 2, 2020
| @@ -85,16 +85,15 @@ out_file <- file.path(root_dir, opts$outfile) | |||
|
|
|||
| #### Read files | |||
|
|
|||
| meta_df <- readr::read_tsv(meta_file, col_types = readr::cols()) | |||
| meta_df <- readr::read_tsv(meta_file, col_types = readr::cols(), guess_max = 10000) | |||
There was a problem hiding this comment.
What is the reason behind adding the guess_max argument to the function here?
There was a problem hiding this comment.
It prevents a warning when readr guesses the wrong data type for some columns (columns that are blank for the first 1000 samples, in this case)
|
Merging over CI failure (for other modules) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What scientific question is your analysis addressing?
Updating analysis for v15
What was your approach?
Replaced
disease-type-newwithintegrated-diagnosisand reran on full dataChanges in subset used for CI were also required due to changes in the included subset.
What GitHub issue does your pull request address?
#574
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
CI config needs to be reverted after passing, and will not pass at that point
Is there anything that you want to discuss further?
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Results
What types of results are included (e.g., table, figure)?
What is your summary of the results?
Reproducibility Checklist
Documentation Checklist
READMEand it is up to date.analyses/README.mdand the entry is up to date.