This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Explicitly add ComplexHeatmap and circlize to Docker container #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I expect this to fail CI because of #574. However, I think we should get the dependencies issues I encountered out of the way by merging this pull request before tackling the rest of the issues related to the v15 release. I'm marking this ready for review. |
|
Was this PR not actually adding circlize #270? |
|
It was closed and not merged. I assume that it was testing something. |
cansavvy
approved these changes
Feb 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
ComplexHeatmapandcirclizewere not explicitly installed in the Docker image, despite being used in multiple analysis modules. This caused intermittent failure, probably due to Docker layer caching in CI. For more context about what I think is happening, see: #577 (comment)What GitHub issue does your pull request address?
#577