-
Notifications
You must be signed in to change notification settings - Fork 83
Update ATRT subtyping to use minimal set of genes #462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This looks good to merge to me! |
Because we had some issues where the SMARCB1 losses were not showing up (#473), I reran this using the new consensus files (from table(old_table$SMARCB1_focal_status, new_table$SMARCB1_focal_status)
loss neutral
loss 20 3
neutral 0 3 (where |
Also add module authors
The most recent non-documentation change (dbc6818) passed, so I'm going to merge this before Circle finishes. |
Purpose/implementation Section
What scientific question is your analysis addressing?
Molecular subtyping of ATRT tumors
What was your approach?
I updated the notebook that generates the final table to use the minimal gene set mentioned here: #244 (comment)
What GitHub issue does your pull request address?
#244
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
View the rendered notebook here: https://jaclyn-taroni.github.io/openpbta-notebook-concept/01-ATRT-molecular-subtyping-data-prep.nb.html
And the table here: https://github.com/jaclyn-taroni/OpenPBTA-analysis/blob/0a452f103324c4f09ab38d039f80d66f494f66b0/analyses/molecular-subtyping-ATRT/results/ATRT_molecular_subtypes.tsv
Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.