This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Add OS_months
to final ATRT molecular subtyping table
#460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
To add
OS_months
column to final ATRT molecular subtyping table.What scientific question is your analysis addressing?
The molecular subtyping of ATRT samples in the OpenPBTA dataset.
What was your approach?
Per #244 (comment), I used the
OS_days
column in thedata/pbta-histologies.tsv
file to calculate the values for the newOS_months
column.What GitHub issue does your pull request address?
This PR addresses issue #244.
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
Does this conversion from days to months appear to be correct?
Is there anything that you want to discuss further?
@jharenza does this satisfy your request?
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes, this PR is ready for review.
Results
What types of results are included (e.g., table, figure)?
The final results file
analyses/molecular-subtyping-ATRT/results/ATRT_molecular_subtypes.tsv
has been updated to include the newOS_months
column.The updated html output can be viewed here.
Note: I reran the
molecular-subtyping-ATRT
module with the data from v13 release.Reproducibility Checklist
Documentation Checklist
README
and it is up to date.analyses/README.md
and the entry is up to date.