Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Recalculate coding TMB with updated Lancet BED file #459

Merged

Conversation

cansavvy
Copy link
Collaborator

Purpose/implementation Section

What scientific question is your analysis addressing?

This PR is updating the TMB coding calculations given the updated Lancet WXS BED file that has been added in v13.

What was your approach?

Because the SNV data itself did not changed, I re-used the latest snv database set (v11) and only recalculated the coding TMB files by revising the WXS coding BED file and then re-running only the 03-calculate-tmb.R script. Based on my knowledge of the changes, nothing else should have to be re-run.

*a minor set of changes I also slipped in in addition to the main BED file changes were some comments and filename changes where I noticed I was still mistakenly referring to exons when I actually meant cds coding sequences.

What GitHub issue does your pull request address?

#440

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Does everything seem in order and does it follow what is expected based on #440?

Results

What types of results are included (e.g., table, figure)?

Revised results have been uploaded to S3. This includes:

What is your summary of the results?

Most of the TMB results are the same, the only thing that has been changed is the denominator for the WXS coding data. The all mutations TMB did not change because Lancet was not used for the all mutations TMB.

Reproducibility Checklist

This was done in the original PRs for this analysis.

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

Documentation Checklist

I took a quick scan through these to make sure no comments needed to be updated in the READMEs and I believe we are set.

  • This analysis module has a README and it is up to date.
  • This analysis is recorded in the table in analyses/README.md and the entry is up to date.
  • The analytical code is documented and contains comments.

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this implementation is consistent with my understanding of #440. Thank you for also making the exon -> cds change!

@jaclyn-taroni jaclyn-taroni merged commit 5bbae49 into AlexsLemonade:master Jan 21, 2020
@cansavvy cansavvy deleted the recalculate-tmb-lancet-bed branch February 6, 2020 21:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants