Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

v13 data release #444

Merged
merged 14 commits into from
Jan 17, 2020
Merged

v13 data release #444

merged 14 commits into from
Jan 17, 2020

Conversation

jharenza
Copy link
Collaborator

@jharenza jharenza commented Jan 16, 2020

Purpose/implementation Section

What scientific question is your analysis addressing?

V13 data release

What was your approach?

NA

What GitHub issue does your pull request address?

#373

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

This is not ready yet (files will be uploaded to S3 after 2PM), but wanted to push the documents through for a look to determine if anything has to change since now we are adding both release-notes.md and data-file-descriptions.md in two places, within the release and in the doc/ folder. Does everything seem appropriately addressed?

Is there anything that you want to discuss further?

@cansavvy can you take a look at the data-file-descriptions.md for the intervals used for TMB?
Are analysis files adequately described?

@jaclyn-taroni I added STAR output files to the gene expression section, but MendQC to a new QC section - does this sound reasonable?

Documentation Checklist

Data Release Checklist

  • Is the table in doc/data-file-descriptions.md up to date?
  • Is doc/data-format.md up to date?
  • Is doc/release-notes.md up to date?
  • Is download-data.sh up to date?

Jo Lynne Rokita added 2 commits January 16, 2020 12:51
add WXS.hg38.lancet.300bp_padded.bed file description
update tcga workflow links, mendqc link
Jo Lynne and others added 2 commits January 16, 2020 13:06
add ticket number from @cgreene suggestion

Co-Authored-By: Casey Greene <cgreene@users.noreply.github.com>
update lancet padding to 400 for WXS, 100 from input file + 300 for padding
@yuankunzhu
Copy link
Collaborator

update release v13
@jharenza
Copy link
Collaborator Author

@jharenza should the release in the data-files-description.md be v13? https://github.com/AlexsLemonade/OpenPBTA-analysis/pull/444/files#diff-0468bf9add309a2a34494766546a847aL18

yes, correct - updated

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a few documentation comments

Jo Lynne Rokita added 2 commits January 16, 2020 15:55
add mendQC file link
move consensus CN file description per @jaclyn-taroni suggestion
Jo Lynne Rokita added 2 commits January 16, 2020 16:55
-add to release chain:
-cnv_consensus.tsv
-intersect_exon_lancet_strelka_mutect_WGS.bed
-intersect_exon_WXS.bed
-intersect_strelka_mutect_WGS.bed
fix filename
-pbta-mend-qc-results.tar.gz
-data-files-descriptions.md
add back gistic file to release notes
@jharenza jharenza added the ready for review Used to label pull requests that are ready for review label Jan 16, 2020
@jharenza
Copy link
Collaborator Author

@jaclyn-taroni the files are uploaded and md5sum updated. i am testing the download now, but should be ready for CI work.

@jharenza
Copy link
Collaborator Author

Data download successful 👍

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: I'll merge once CI finishes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready for review Used to label pull requests that are ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants