This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 83
Chromosomal Instability (PR 2 of 3): The functions #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjspielman
reviewed
Jan 8, 2020
sjspielman
reviewed
Jan 8, 2020
sjspielman
reviewed
Jan 8, 2020
sjspielman
reviewed
Jan 8, 2020
sjspielman
reviewed
Jan 8, 2020
sjspielman
reviewed
Jan 8, 2020
sjspielman
reviewed
Jan 8, 2020
sjspielman
reviewed
Jan 8, 2020
sjspielman
reviewed
Jan 8, 2020
3 tasks
jaclyn-taroni
approved these changes
Jan 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a few typos and it looks like all of @sjspielman's comments have been addressed for the moment. I am going to approve in the interest of making #419 a bit more manageable, but we can revisit these files if something comes up during that review. I will commit my suggested changes.
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
This second PR has the functions that will be used for calculating and plotting chromosomal breakpoints.
What scientific question is your analysis addressing?
This was the task:
I borrowed concepts from https://github.com/gonzolgarcia/svcnvplus for generating breakpoint density. I calculate breakpoint density and in a later PR, I will plot this data by tumor type.
What was your approach?
These functions calculate breakpoint density for CNV, SV and combined CNV and SV and them plot them. I have an example of the output plot below.
What GitHub issue does your pull request address?
The first part of #394 (the recurrently altered genes part will be a different PR series that will undoubtedly use the functions this PR series uses as well as maybe additional ones).
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
I have ideas about how to make these functions more generalizable, but before I get too far into the weeds, I need another pair of eyes to let me know how they look so far.
- ...Efficient?
- ...DRYer?
- ...Easier to use?
- ...Better documented?
Keep in mind, I realize the comments and suggestions about these functions make change as you see them being used in context in the subsequent PRs. Don't worry about them being perfect in context at this stage, I'm more looking for places where my approach should be changed or optimized in general.
Results
No results yet, that will be the next PR, just the functions. Here's an example plot of what these functions create:
Reproducibility Checklist
This will be added to circleCI in the third PR. There are no new packages that need to be added to the Dockerfile so that is set.
analyses/README.md
.