Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Add snakemake to Docker #285

Closed
wants to merge 1 commit into from
Closed

Add snakemake to Docker #285

wants to merge 1 commit into from

Conversation

nhatduongnn
Copy link
Contributor

Purpose/implementation Section

This is adding Snakemake into the Dockerfile

What scientific question is your analysis addressing?

It is addressing issue #128

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.
  • This analysis has been added to continuous integration.

@cgreene
Copy link
Collaborator

cgreene commented Nov 21, 2019

Is there a reason to setup things this way instead of just using pip3 to install snakemake as was done for the other python dependencies a few lines above this?

@nhatduongnn
Copy link
Contributor Author

Dear Dr. Greene,

Pip3 snakemake does not work due to a problem with Datrie.
Then I tried to pip the newest version of Datrie but the pip failed. It seems that there is something wrong with Datrie's pip installation.
Due to time constraints, I had to forgo the pip3 install and use this approach instead.

I tried every single installation method suggested in the Snakemake documents and the only ones that work are conda install and what I have done in the Dockerfile.
Conda is the most straightforward way but from past experience, I do not think it is feasible to add conda into the docker at this point.

Thank you,

Nhat Duong

@cgreene
Copy link
Collaborator

cgreene commented Nov 21, 2019

Interesting! I created #286 to investigate while my local Docker is updating. Thanks for noting this. I'll see what I can nail down, and if we can't get pip3 to go then we can go this route.

@jashapiro
Copy link
Member

It looks like the datrie dependency problem may have been fixed:

datrie 0.8 has been released on pypi, resolving this issue
https://bitbucket.org/snakemake/snakemake/issues/934/installation-failed-in-python-37

But it also appears that this problem may have been restricted to python 3.7, and the image we are using has python 3.5.3, so this bug may not be relevant to this install.

It does look like the pip3 install in #286 was successful, so that may be the way to go for installation if it can work for your application.

@cgreene
Copy link
Collaborator

cgreene commented Nov 22, 2019

Ok! You should be able to pull upstream master @fingerfen and be good to go. You may already have it set up, but just in case you don't:
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork

Thanks for your contributions!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants