Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Data release/add v5 release #127

Merged
merged 13 commits into from
Sep 25, 2019
Merged

Data release/add v5 release #127

merged 13 commits into from
Sep 25, 2019

Conversation

yuankunzhu
Copy link
Collaborator

@yuankunzhu yuankunzhu commented Sep 25, 2019

Purpose/implementation

data release updates for v5

Issue/Caveats

Directions for reviewers

changed on release notes and download script.

  • file content updated for pbta-fusion-arriba.tsv.gz and md5sum.txt.
  • add file *.polya.rds, *.stranded.rds, *.bed pbta-snv-lancet.vep.maf.gz and pbta-snv-vardict.vep.maf.gz
  • remove file pbta-gene-expression-kallisto.rds and pbta-gene-expression-rsem-fpkm.rds

Results

Docker and continuous integration

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that I can successfully run bash download-data.sh with this branch checked out.

@jaclyn-taroni
Copy link
Member

Thanks for noting the breaking changes @yuankunzhu. We will not have issues with the tests breaking at the moment because until I tackle #124 (hopefully today or tomorrow) the files specifically for testing will be tied to the v4 release.

@@ -28,7 +80,8 @@ data
├── pbta-snv-mutect2.vep.maf.gz
├── pbta-snv-strelka2.vep.maf.gz
├── pbta-sv-lumpy.tsv.gz
└── pbta-sv-manta.tsv.gz
├── pbta-sv-manta.tsv.gz
└── README.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuankunzhu this essentially reverts a change introduced in #107. Can you remove this reference to a README please? I would fix myself and merge but I can't push to this branch.

@jaclyn-taroni
Copy link
Member

I will make this small change #127 (comment) when I address #124. Merging so folks can get started on their updates.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants