-
Notifications
You must be signed in to change notification settings - Fork 83
PR 1 of n: README with first part of SNV caller analysis #114
PR 1 of n: README with first part of SNV caller analysis #114
Conversation
@cansav09 I am assuming that you may have put together the table of contents here manually. We use this package for the refine.bio README ToC IIRC: https://www.npmjs.com/package/doctoc just FYI |
Oh nice. Didn't know such things existed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small things. This seems like a reasonable plan to me. I feel like I can't thoroughly evaluate the functions without looking at the code. Would be good to have @jashapiro give this a once over as well.
@cansav09 can I mark this as ready for review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I expect there will be changes as the other PRs come in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 We'll get this merged in and then up date it as needed.
Purpose/implementation
Preparing a pipeline to perform an initial analysis and calculation of each MAF file for each SNV caller. At this point, the SNV callers that will be evaluated are MuTect2, Strelka2, VarDict, and Lancet.
Issue
For SNV caller comparison #103 and Tumor Mutation Burden #3
Directions for reviewers
For this first Draft PR, I'm just pushing the README I've created for this analysis so I can get overall advice on this pipeline. If it's too difficult to evaluate this without the code, let me know and I will reformulate my PR.
Main things I am looking for advice on:
I will continue working on the wording of this document, so do worry about wording/grammar too much, unless my wording at any point is making it difficult to understand, then please let me know.
Results
No results just yet, because we don't yet have all the data.
Docker and continuous integration
These things will be in a future PR.