Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Updated analysis: histology-treemap.html is broken -- probably delete it? #920

Open
cansavvy opened this issue Jan 22, 2021 · 1 comment

Comments

@cansavvy
Copy link
Collaborator

What analysis module should be updated and why?

sample-distribution-analyses, specifically the histology-treemap.html plot.

What changes need to be made? Please provide enough detail for another participant to make the update.

plots/histology-treemap.html shows up as a black rectangle. I'm not sure if this plot is being used other places. We may just want to get rid of it.

You can see the original comment here:
#918 (review)

What input data should be used? Which data were used in the version being updated?

Should be as simple as getting rid of the lines in 02-multilayer-plots.R that make that plot.

Who will complete the updated analysis?

I can do this in a PR later probably.

@jharenza
Copy link
Collaborator

Agree with removing - I think we can use the pie chart as the sample distribution figure, with modifications as noted in #1144

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants