Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Rerun "PBTA histologies" PR code once they are all merged or reexamine results #891

Closed
jaclyn-taroni opened this issue Jan 6, 2021 · 4 comments
Labels

Comments

@jaclyn-taroni
Copy link
Member

In the interest of getting the following pull requests through:

#863
#864
#865
#866
#868
#869
#870

I am fixing merge conflicts by accepting the changes in master – which will be the changes in the earlier (but presumably more recently updated wrt to files with conflicts) pull requests – without critically examining the changes in results files. Once all of these have been approved and merged, we should create a new branch, rerun all of those steps, and examine the diffs for unexpected changes. Since I understand that these pull requests are upstream of the v18 release, we should do this before we merge #867.

Tagging @kgaonkar6 and @jharenza who are more familiar with the code and results in those pull requests.

@kgaonkar6
Copy link
Collaborator

I just wanted to confirm that when we re-run the "PBTA histologies" PRs mentioned above using the new base histology file fixing #899, the pbta-histologies.tsv created will be used for v18 release #857, right?

@jharenza
Copy link
Collaborator

jharenza commented Jan 7, 2021

Yes!

@jaclyn-taroni
Copy link
Member Author

Closed via #896 - is that correct @kgaonkar6 ?

@kgaonkar6
Copy link
Collaborator

Yes!! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants