You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
What changes need to be made? Please provide enough detail for another participant to make the update.
Currently, the TMB we are using for comparisons includes all mutations in coding regions (with the caveat that there currently a bug as described in #724). To better conform with emerging standards, as implemented in #725, we should update our TMB calculations to use only the following non-synonymous changes: Missense_Mutation In_Frame_Del Nonsense_Mutation In_Frame_Ins Frame_Shift_Del Frame_Shift_Ins
One note, is that this list of non-synonymous mutation types is slightly shorter than the one used in MAFtools, and implemented here:
It is likely that we will want to make this optional in the enclosing function.
What input data should be used? Which data were used in the version being updated?
Input data is the same as previously.
When do you expect the revised analysis will be completed?
The actual changes are small and should be quick. Downstream consequences may take longer to sort out.
Who will complete the updated analysis?
TBD; could be implemented alongside the changes to fix #724, as both will require updating of downstream analyses, and we may not want to do that more than once!
The text was updated successfully, but these errors were encountered:
What analysis module should be updated and why?
snv-callers
, specificallyhttps://github.com/AlexsLemonade/OpenPBTA-analysis/blob/master/analyses/snv-callers/scripts/03-calculate_tmb.R
and
https://github.com/AlexsLemonade/OpenPBTA-analysis/blob/master/analyses/snv-callers/util/tmb_functions.R
What changes need to be made? Please provide enough detail for another participant to make the update.
Currently, the TMB we are using for comparisons includes all mutations in coding regions (with the caveat that there currently a bug as described in #724). To better conform with emerging standards, as implemented in #725, we should update our TMB calculations to use only the following non-synonymous changes:
Missense_Mutation
In_Frame_Del
Nonsense_Mutation
In_Frame_Ins
Frame_Shift_Del
Frame_Shift_Ins
One note, is that this list of non-synonymous mutation types is slightly shorter than the one used in MAFtools, and implemented here:
OpenPBTA-analysis/analyses/interaction-plots/scripts/02-process_mutations.R
Lines 263 to 274 in 5b38033
We should probably standardize these two.
This change can be implemented by adding a
dplyr::filter()
step here:OpenPBTA-analysis/analyses/snv-callers/util/tmb_functions.R
Line 133 in 5b38033
It is likely that we will want to make this optional in the enclosing function.
What input data should be used? Which data were used in the version being updated?
Input data is the same as previously.
When do you expect the revised analysis will be completed?
The actual changes are small and should be quick. Downstream consequences may take longer to sort out.
Who will complete the updated analysis?
TBD; could be implemented alongside the changes to fix #724, as both will require updating of downstream analyses, and we may not want to do that more than once!
The text was updated successfully, but these errors were encountered: