Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No image cropping #1913

Closed
dhughesbc opened this issue Jul 30, 2020 · 3 comments
Closed

No image cropping #1913

dhughesbc opened this issue Jul 30, 2020 · 3 comments

Comments

@dhughesbc
Copy link
Contributor

Steps to reproduce

Install alchemy in an existing rails app

Expected behavior

After uploading an image, docs indicate you should be able to crop the image (possibly by clicking on the image? docs not clear).

Actual behavior

Do not see any way to crop an image.

System configuration

  • Alchemy Version: 5.0.0
  • Rails Version: 6.0.3.2
@tvdeyen
Copy link
Member

tvdeyen commented Jul 30, 2020 via email

@dhughesbc
Copy link
Contributor Author

dhughesbc commented Jul 31, 2020

There is not any specific place it says anything either way, but on this page https://alchemy-cms.com/tour, there is indication that you can crop images. There is no mention that it needs to be explicitly enabled.

Now that I understand it needs to be enabled, I see this in the config: https://github.com/AlchemyCMS/alchemy_cms/blob/master/config/alchemy/config.yml#L63-L79 but it is confusing. This line indicates a hash to set config:

# Alchemy uses Dragonfly to render images. Use {size: "XXXxYYY", crop: BOOLEAN [true]} to resize images.

But this line says to use a string:

# preprocess_image_resize [String] # Use this option to resize images to that value. Downsizing example: '1000x1000>' (Default nil)

@dhughesbc
Copy link
Contributor Author

The issue for me was confusion the documentation. There is s a comment/example in one config that is meant to be applied in a different config file. I have created a PR that clarifies #1917

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants