From d639170e519562617f2d3aba4bd1e5d1a23f8a96 Mon Sep 17 00:00:00 2001 From: Thomas von Deyen Date: Mon, 22 Jan 2018 14:16:03 +0100 Subject: [PATCH] Don't prevent submit event of element save button The onClickElement handler must not prevent the default browser event, if the event target is a submit button. --- .../javascripts/alchemy/alchemy.element_editors.js.coffee | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/alchemy/alchemy.element_editors.js.coffee b/app/assets/javascripts/alchemy/alchemy.element_editors.js.coffee index 9c1cfdf473..d8411b5c41 100644 --- a/app/assets/javascripts/alchemy/alchemy.element_editors.js.coffee +++ b/app/assets/javascripts/alchemy/alchemy.element_editors.js.coffee @@ -186,11 +186,13 @@ Alchemy.ElementEditors = # - Triggers custom 'SelectPreviewElement.Alchemy' event on target element in preview frame. # onClickElement: (e) -> - $element = $(e.target).closest(".element-editor") + $target = $(e.target) + $element = $target.closest(".element-editor") element_id = $element.attr("id").replace(/\D/g, "") @selectElement($element) @selectElementInPreview(element_id) - e.preventDefault() + # Element submit button needs to keep it's default event + e.preventDefault() unless $target.is(':submit') return # Double click event handler for element head.