Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket server timeout #73

Closed
tylxm opened this issue Feb 14, 2020 · 4 comments
Closed

Websocket server timeout #73

tylxm opened this issue Feb 14, 2020 · 4 comments

Comments

@tylxm
Copy link

tylxm commented Feb 14, 2020

I'm using nginx as proxy server for secure websocket connection, but every 60 seconds, the browser will close the websocket connection, after some investigation, I found there's a timeout setting in Nginx called proxy_read_timeout, this value is default 60 seconds, can we add some timeout to the server to let client keep alive?

btw, do we really need to keep the websocket connection alive? can we just close websocket after webrtc connection connected?

I mean can we just comment this line out?

DisconnectInternal(remote);

@dimiden
Copy link
Member

dimiden commented Feb 17, 2020

@ytian801
Which version are you using? If it is a version of the master branch, the "WebSocket ping-pong" specification is not implemented, which can cause problems.
(This problem has been fixed in commit fa7b057)

@tylxm
Copy link
Author

tylxm commented Feb 17, 2020

I'm using master branch

@dimiden
Copy link
Member

dimiden commented Feb 24, 2020

@ytian801
Then, as I said above, I don't think it works because of the ping-pong specification.
We are currently working on merging two branches (master/dev), so please wait for it or use the dev branch.

@getroot getroot closed this as completed Mar 30, 2020
@getroot
Copy link
Member

getroot commented Mar 30, 2020

This issue has been closed since it has been inactive for quite some time. If you want to continue discussing this issue, please feel free to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants