Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lien support from cosmos-sdk #8989

Closed
JimLarson opened this issue Feb 25, 2024 · 0 comments · Fixed by agoric-labs/cosmos-sdk#385
Closed

Remove lien support from cosmos-sdk #8989

JimLarson opened this issue Feb 25, 2024 · 0 comments · Fixed by agoric-labs/cosmos-sdk#385
Assignees
Labels
agoric-cosmos enhancement New feature or request

Comments

@JimLarson
Copy link
Contributor

What is the Problem Being Solved?

Modifications were made to the cosmos-sdk x/auth module to support the lien mechanism which has been deprecated and removed from agoric-sdk (swingset side in #7608, golang side in #8988, issue #8987). Since those modifications are no longer needed, we should remove them to reduce our fork footprint and ease future cosmos-sdk upgrades.

Description of the Design

  • Undo the conversion of AccountKeeper into an interface, mostly in x/auth/keeper
  • Remove the *Action interfaces for vesting accounts and simplify the implementations of AddGrant, ReturnGrant, Clawback, etc. Might need to keep RewardAction? (x/auth/vesting/exported, x/auth/vesting/types)
  • We might be able to remove the sdk.Context argument in VestingAccount.LockedCoins back to time.Time (x/auth/vesting, x/bank/keeper).
  • Distribution hooks will still be needed for Clawback accounts, but the planned changes for BLD Boost reward interception can be dropped.

Security Considerations

Should improve things by getting closer to stock cosmos-sdk.

Scaling Considerations

N/A

Test Plan

N/A. Unit tests should suffice.

Upgrade Considerations

N/A. The account-wrapping feature was designed to not have any impact on stored state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agoric-cosmos enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant