Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop limiting $block['keywords'] to only three items #227

Closed
hacknug opened this issue Sep 26, 2019 · 4 comments
Closed

Stop limiting $block['keywords'] to only three items #227

hacknug opened this issue Sep 26, 2019 · 4 comments

Comments

@hacknug
Copy link

hacknug commented Sep 26, 2019

Gutenberg's core used to limit the number of keywords to three and, to prevent JS issues with that, you were slicing $block['keywords'] to only get the first three items.

This limitation doesn't exist anymore and should be removed so things work as expected. Lines 190–192 in pro/blocks.php.

@elliotcondon
Copy link
Contributor

Hi @hacknug

Thanks for the topic.
Do you know which version of WP introduced the change?

@hacknug
Copy link
Author

hacknug commented Sep 27, 2019

It was this PR which was assigned to the 5.1 milestone. Here's the changelog for that version: https://github.com/WordPress/gutenberg/releases/tag/v5.1.0

@elliotcondon
Copy link
Contributor

Thanks @hacknug

I'll add this to my to-do list.

@elliotcondon
Copy link
Contributor

@hacknug I have implemented a fix for this issue and will include it in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants