Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] husky postinstall fatal error #328

Closed
1 of 2 tasks
JoernBerkefeld opened this issue Jun 14, 2022 · 1 comment
Closed
1 of 2 tasks

[BUG] husky postinstall fatal error #328

JoernBerkefeld opened this issue Jun 14, 2022 · 1 comment
Assignees
Labels
bug Something isn't working e/IDE EPIC wontfix This will not be worked on

Comments

@JoernBerkefeld
Copy link
Contributor

JoernBerkefeld commented Jun 14, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

when installing it locally and using the foreground-scripts flag one sees this issue:

08:40:26	> mcdev@3.1.3 prepare
08:40:26	> husky install
08:40:26	
08:40:26	fatal: not a git repository (or any of the parent directories): .git

image

Expected Behavior

husky hooks installed i suppose?

Steps To Reproduce

run npm install --save accenture/sfmc-devtools#bug328 --foreground-scripts

Version

develop-branch

Environment

  • OS:
  • Node:
  • npm:

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

there is a bug in husky's repo at typicode/husky#584 with a solution it seems but I don't fully understand what were are doing here to begin with and hence would like you to deal with it, @DougMidgley

@JoernBerkefeld JoernBerkefeld added bug Something isn't working NEW not yet analyzed new issues get this label labels Jun 14, 2022
@JoernBerkefeld JoernBerkefeld added this to the 4.0.1 milestone Jun 14, 2022
@JoernBerkefeld JoernBerkefeld added e/IDE EPIC wontfix This will not be worked on and removed NEW not yet analyzed new issues get this label labels Jun 14, 2022
@JoernBerkefeld JoernBerkefeld removed this from the 4.0.1 milestone Jun 15, 2022
@JoernBerkefeld
Copy link
Contributor Author

noticed that this only happens if mcdev is installed via npm directly - but not if its repo is cloned and npm i is run afterwards.
... and that kinda makes sense cause it's only relevant for people contributing to mcdev --> closed.

FYI @DougMidgley

@JoernBerkefeld JoernBerkefeld closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2022
@JoernBerkefeld JoernBerkefeld moved this to Done in mcdev Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working e/IDE EPIC wontfix This will not be worked on
Projects
Status: Done
Development

No branches or pull requests

2 participants