Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM: Scheduler handle transaction fee #700

Closed
xlc opened this issue Jan 27, 2021 · 0 comments · Fixed by #723
Closed

EVM: Scheduler handle transaction fee #700

xlc opened this issue Jan 27, 2021 · 0 comments · Fixed by #723
Assignees
Milestone

Comments

@xlc
Copy link
Member

xlc commented Jan 27, 2021

The transaction fee for scheduled calls are not handled correctly currently.

Should run the call, know how much gas is used, calculate the fee, unreserve previously reserved fee, use module-transaction-payment to charge the fee. May need some new trait to handle the fee.

.saturating_add(gas_limit.into());

The reserve logic isn't correct here, should convert gas limit to weight and maybe use some new trait implemented by module-transaction-payment to convert weight to balances.

@xlc xlc mentioned this issue Jan 27, 2021
@zjb0807 zjb0807 self-assigned this Jan 28, 2021
@xlc xlc added this to the 2.0 milestone Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants