Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: activate/setup initial config #2804

Closed
sleidig opened this issue Jan 23, 2025 · 4 comments
Closed

Notifications: activate/setup initial config #2804

sleidig opened this issue Jan 23, 2025 · 4 comments
Assignees
Milestone

Comments

@sleidig
Copy link
Member

sleidig commented Jan 23, 2025

To generate Notifications, a user needs a "NotificationConfig" entity with the individual settings. The system has to create this initially, if not already present. Also, the system should already provide some commonly needed default Notification Rules to help users, especially if a person has no special needs and little technical knowledge.

Default Rules to be automatically created ("Notify me when ..."):

  • "a new Child is registered" -> any new "Child" entity
  • "a Task is assigned to me" -> any new/updated "Task" entity if "Assigned to" === CurrentUserSubject.value.getId()
  • "a Note involving me is updated" -> any new/updated "Note" entity if "Team involved" includes CurrentUserSubject.value AND updated.by is not CurrentUserSubject.value.getId()

Implementation to create initial NotificationConfig entity:

  • Option A: in notification window (from toolbar) initially display "Notifications disabled. [Set up now]" -> Navigate to Settings Page -> Create and save default NotificationConfig by Settings page, if not found
  • Option B: after initial sync, check if present and otherwise create
@sleidig sleidig added this to the Notifications milestone Jan 23, 2025
@github-project-automation github-project-automation bot moved this to Triage / Analysis in All Tasks & Issues Jan 23, 2025
@sleidig sleidig moved this from Triage / Analysis to Planned (current "sprint") in All Tasks & Issues Jan 23, 2025
@sleidig
Copy link
Member Author

sleidig commented Jan 23, 2025

I would tend towards Option A for the process of creating the initial config but am not completely sure. What do you think, @tomwwinter , @george-neha , @Ayush8923 ?

@Ayush8923
Copy link
Contributor

I also vote for option A. However, I have one question, do we need to add the Set up now option inside the notification list, or should we create a different icon for this? If notifications are disabled for the application?

@sleidig
Copy link
Member Author

sleidig commented Jan 23, 2025

I would replace the icon + "you have no notifications" (maybe actually also hiding the tabs all/unread) with a different text + button "Set up now".

Image

@george-neha
Copy link

I prefer Option A because it's functional and provides a clear path for setup. But what if we enable some default notifications and then nudge the user to tweak them according to their requirement?

@Ayush8923 Ayush8923 moved this from Planned (current "sprint") to In Progress in All Tasks & Issues Jan 24, 2025
@sleidig sleidig closed this as completed Jan 26, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in All Tasks & Issues Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants