Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch sum_utils to use AMReX volwgtsum #2276

Open
zingale opened this issue Sep 25, 2022 · 1 comment
Open

switch sum_utils to use AMReX volwgtsum #2276

zingale opened this issue Sep 25, 2022 · 1 comment

Comments

@zingale
Copy link
Member

zingale commented Sep 25, 2022

AMReX now has a volwgtsum function:
AMReX-Codes/amrex#2961

we should be able to use this in place of the Castro version in sum_utils.cpp

@maximumcats
Copy link
Member

I'd have to remember more closely why I did #2158 in order to get to #2164, but just worth noting for later that AMReX now does this a little different from Castro. Some uses of volWgtSum in Castro (though perhaps not the ones in sum_utils.cpp) might require an update to the AMReX version to take an Array4 representing the mask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants