Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start script does not handle signals #3

Open
AGSPhoenix opened this issue Apr 10, 2016 · 3 comments
Open

Start script does not handle signals #3

AGSPhoenix opened this issue Apr 10, 2016 · 3 comments

Comments

@AGSPhoenix
Copy link
Owner

With the new signal handling in the client, being able to send a ctrl-c via docker kill would be a nice feature.

@CryoRig
Copy link
Contributor

CryoRig commented Oct 20, 2017

docker stop {dockername} works fine for me...
if you still want a ctrl-c, i can look into it, shouldn't be hard

@AGSPhoenix
Copy link
Owner Author

My desire with this was to have the client's graceful shutdown capability usable from docker commands. Given that docker stop defaults to a 10 second delay before killing the container though, and an ongoing render could take upwards of half an hour to complete, that may simply not be feasible. If you want to take a look, let me know how it goes.

@DaCoolX
Copy link
Contributor

DaCoolX commented Feb 15, 2019

Since this issue was created docker runtime added support for the --init option,
If enabled it just interjects the tini init system, which handles signal handling and process reaping automatically (the latter won't be an issue in sheepit's case most likely) and doesn't interfere with anything else.
Though it would most likely kill the render process immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants