Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't the traits in fuzzer.rs just be a public function? #2894

Closed
tokatoka opened this issue Jan 26, 2025 · 5 comments
Closed

Shouldn't the traits in fuzzer.rs just be a public function? #2894

tokatoka opened this issue Jan 26, 2025 · 5 comments
Assignees
Milestone

Comments

@tokatoka
Copy link
Member

Evaluator, ExecutionProcessor, EvaluatorObservers.

These traits are causing problems for me and I can't continue on #2872
and i don't see any reason why we can't just use public function instead.
We can just use the implementation of StdFuzzer for these traits.

@domenukk
Copy link
Member

Functions cannot be overridden right?
Or do you want to pass them in somehow?

@tokatoka
Copy link
Member Author

i don't think functions Evaluator, ExecutionProcessor, EvaluatorObservers. should be overridden

@tokatoka
Copy link
Member Author

btw this is another problem cyclic dependency.
fuzzer uses event manager inside. but event manager calls into fuzzer function too.

@tokatoka
Copy link
Member Author

@addisoncrump
opinion?

@tokatoka
Copy link
Member Author

tokatoka commented Jan 27, 2025

another solution to #2872 is to remove EM from all these traits.
ExecutionProcessor<EM, I, OT, S> to ExecutionProcessor<I, OT, S>
and
EvaluatorObservers<E, EM, I, S> to EvaluatorObservers<E, I, S>
and move them to each function
but this sounds wrong to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants