Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and change hall sensor reading in Calibration::isInField #1

Open
V3lop5 opened this issue Oct 19, 2022 · 0 comments
Open

Test and change hall sensor reading in Calibration::isInField #1

V3lop5 opened this issue Oct 19, 2022 · 0 comments

Comments

@V3lop5
Copy link
Contributor

V3lop5 commented Oct 19, 2022

Previously the magnetic field measured with analogRead. Due to poor performance of over 100 μs this must be changed to digitalRead. This change is not tested so far.

return digitalRead(this->hall_pin) == LOW;

If digitalRead works fine, we should change it to FastGPIO::Pin<THE_HALL_PIN>::isInputLow().
This change will increase the performance from 5.1 μs to 0.125 μs.

After that change the clock communication should be more stable, and we can increase the frequency even more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant