Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIApplication:open handler is conflicting with uni_links plugin #47

Closed
ajinasokan opened this issue Oct 22, 2021 · 1 comment
Closed

Comments

@ajinasokan
Copy link

As per Flutter engine implementation UIApplication:open is suppose to return false if link is not handled by the plugin.

https://github.com/flutter/engine/blob/138c91c614d742c52aa5432b4cb921f0ff9fdee2/shell/platform/darwin/ios/framework/Source/FlutterPluginAppLifeCycleDelegate.mm#L313-L327

But in home_widget plugin it is always returning true and this blocks plugins like uni_links to get the URL.

public func application(_ application: UIApplication, open url: URL, options: [UIApplication.OpenURLOptionsKey : Any] = [:]) -> Bool {
if(isWidgetUrl(url: url)) {
latestUrl = url
}
return true
}

I have a fix in #46 that properly returns the flag.

@ABausG
Copy link
Owner

ABausG commented Nov 21, 2021

Fixed by #42 will be in the next release

@ABausG ABausG closed this as completed Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants