Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 5.2.0 doesn't specify deep-equal as a dependency, but still tries to require it #502

Closed
TomerAberbach opened this issue Jun 13, 2023 · 6 comments · Fixed by aws-amplify/amplify-ui#4093

Comments

@TomerAberbach
Copy link

Go to https://www.npmjs.com/package/aria-query?activeTab=code and then lib/elementRoleMap.js and you can see the transpiled file contains the following line:

var _deepEqual = _interopRequireDefault(require("deep-equal"));

This fails because deep-equal isn't installed.

@gtm-nayan
Copy link
Contributor

Copying over my comment from #497

It's used on this line in the file on npm, but it's been already converted to dequal. The only reference to deep-equal I can find in this repo now is in a flow definitions file.

Building it locally gives me the correct "dequal" import.

@jessebeach
Copy link
Member

Alright, let's get that fixed. New version inbound in a few minutes.

@jessebeach
Copy link
Member

So weird, it's like npm publish didn't run npm build. :/

@jessebeach
Copy link
Member

Fixed in v5.2.1

I need to investigate why npm publish doesn't run npm build.

@jessebeach
Copy link
Member

@TomerAberbach does version v5.2.1 fix the issue for you?

@TomerAberbach
Copy link
Author

Yup, solved for me. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants