From b37befb243a66e7b51d3c4715166cd1f77cf4b64 Mon Sep 17 00:00:00 2001
From: joshuaboud <joshuaboud@hotmail.com>
Date: Fri, 14 Jun 2024 14:41:36 -0300
Subject: [PATCH] default new samba share to read only = false

---
 file-sharing/src/tabs/samba/data-types.ts      | 8 +++++++-
 file-sharing/src/tabs/samba/ui/ShareEditor.vue | 4 ++--
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/file-sharing/src/tabs/samba/data-types.ts b/file-sharing/src/tabs/samba/data-types.ts
index 914f21c..2943538 100644
--- a/file-sharing/src/tabs/samba/data-types.ts
+++ b/file-sharing/src/tabs/samba/data-types.ts
@@ -1,4 +1,5 @@
 import { type KeyValueData } from "@45drives/houston-common-lib";
+import { readonly } from 'vue';
 
 export type SambaGlobalConfig = {
   logLevel: number;
@@ -23,7 +24,7 @@ export type SambaConfig = {
   shares: SambaShareConfig[];
 };
 
-export const defaultSambaShareConfig = (name: string = "") => ({
+export const defaultSambaShareConfig = (name: string = ""): SambaShareConfig => ({
   name,
   description: "",
   path: "",
@@ -34,6 +35,11 @@ export const defaultSambaShareConfig = (name: string = "") => ({
   advancedOptions: {},
 });
 
+export const newSambaShareConfig = (): SambaShareConfig => ({
+  ...defaultSambaShareConfig(""),
+  readOnly: false,
+})
+
 export const defaultSambaGlobalConfig = () => ({
   serverString: "Samba %v",
   logLevel: 0,
diff --git a/file-sharing/src/tabs/samba/ui/ShareEditor.vue b/file-sharing/src/tabs/samba/ui/ShareEditor.vue
index 8ce38b4..d229265 100644
--- a/file-sharing/src/tabs/samba/ui/ShareEditor.vue
+++ b/file-sharing/src/tabs/samba/ui/ShareEditor.vue
@@ -14,7 +14,7 @@ import {
   validationError,
   ValidationResultView,
 } from "@45drives/houston-common-ui";
-import { type SambaShareConfig, defaultSambaShareConfig } from "@/tabs/samba/data-types";
+import { type SambaShareConfig, newSambaShareConfig } from "@/tabs/samba/data-types";
 import { KeyValueSyntax } from "@45drives/houston-common-lib";
 import { BooleanKeyValueSuite } from "@/tabs/samba/ui/BooleanKeyValueSuite"; // TODO: move to common-ui
 import ShareDirectoryInputAndOptions from "@/common/ui/ShareDirectoryInputAndOptions.vue";
@@ -44,7 +44,7 @@ const emit = defineEmits<{
 const globalProcessingState = useGlobalProcessingState();
 
 const shareConf = computed<SambaShareConfig>(() =>
-  props.newShare ? defaultSambaShareConfig() : props.share
+  props.newShare ? newSambaShareConfig() : props.share
 );
 
 const { tempObject: tempShareConfig, modified, resetChanges } = useTempObjectStaging(shareConf);