-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIC/AIC/DOF not correct since Version 0.85 #125
Comments
Sorry I will have to take that back..... my mistake from a previous fit. However, BIC/AIC and DOF seems to not update properly from the GUI side when the fit is initialized with a different number of fitted parameters..... More investigation is needed! |
Hi Trifon, When I tried to install the latest version of Exostriker within the anaconda environment, one of the errors is about "rv_mod", here is the error shown in the terminal:
Now I just passed using Anaconda and it becomes super easy and smoothly to install the Exostriker(0.86 ver.)! So, the issue about "rv_mod" won't be a problem anymore... But everytime I open the exostriker, this warning occurs:
However, I found that it became harder to make a better fit. I mean, it could derive a quite correct and good result by merely click the "RV Auto fit" in the old ver. of Exostriker, but now, it's pretty difficult to fit it well with the same dataset. I don't know if this is a problem... So, these are a few problems after installing the latest version of Exostriker on iMac(Mac Ventura 13.5.2, intel core i7). Looking forward to your reply! Thanks! Best, |
Hi @Astrocyy, First, let us open another "issue" :) There I will answer your questions :) This thread I will close since I think the BIC/AIC and DOF values are now correct. |
Hi again @Astrocyy, Regardng your first problem I have open an issue here: For the second one:
The problem was that I have made the SciPyOp the default optimizer, because @MatheusJCastro and I have made many improvements in the Exo-Striker's RV-model speed. However, I see that the SciPyOp is not always converging well. One has to play a bit with the SciPyOp options (Model Opt. --> SciPy opt., --> and e.g., Nelder-Mead options), but I see this could be cumbersome for the user. I will work in the direction to somehow make the SciPyOp to choose the appropriate options automatically, if that is possible at all. OK, I am rolling back the default Fortran optimizer. Please git pull and do your tests again. Keep in mind, however, that the Fortran optimization code cannot accept limits and priors, whereas SciPyOp can (albite being the slower option). You can always swap between SciPyOp and the default RVmod optimizer in (Model Opt. --> RV model). Let me know if you still have problems, |
Hi Trifon, I saw the #126 last night. Thank you so much for your quick reply! The major problem now is that the whole exostriker always crashed suddenly and need reopen after I just started to fix the RV data. And everytime I open the exostriker, these warnings occurs:
Then I tried
I don't know if there is something wrong with the Python(3.11.7 ver.).. Best, |
I suspect that rvmod_for.f95 returns a wrong 'mfit' output?
TBCheked!
The text was updated successfully, but these errors were encountered: