Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIC/AIC/DOF not correct since Version 0.85 #125

Closed
3fon3fonov opened this issue Dec 5, 2023 · 6 comments
Closed

BIC/AIC/DOF not correct since Version 0.85 #125

3fon3fonov opened this issue Dec 5, 2023 · 6 comments
Assignees

Comments

@3fon3fonov
Copy link
Owner

3fon3fonov commented Dec 5, 2023

I suspect that rvmod_for.f95 returns a wrong 'mfit' output?

TBCheked!

@3fon3fonov
Copy link
Owner Author

Sorry I will have to take that back..... my mistake from a previous fit. However, BIC/AIC and DOF seems to not update properly from the GUI side when the fit is initialized with a different number of fitted parameters..... More investigation is needed!

@3fon3fonov 3fon3fonov self-assigned this Dec 5, 2023
@Astrocyy
Copy link

Astrocyy commented Dec 6, 2023

Hi Trifon,

When I tried to install the latest version of Exostriker within the anaconda environment, one of the errors is about "rv_mod", here is the error shown in the terminal:

ImportError: cannot import name 'rvmod_for' from partially initialized module 'RV_mod.rvmod' (most likely due to a circular import)

Now I just passed using Anaconda and it becomes super easy and smoothly to install the Exostriker(0.86 ver.)! So, the issue about "rv_mod" won't be a problem anymore...

But everytime I open the exostriker, this warning occurs:
(I don't know if it's the problem of the Python not about Exostriker and I have no idea how to fix it or just neglect it...)

0.00s - Debugger warning: It seems that frozen modules are being used, which may
0.00s - make the debugger miss breakpoints. Please pass -Xfrozen_modules=off
0.00s - to python to disable frozen modules.
0.00s - Note: Debugging will proceed. Set PYDEVD_DISABLE_FILE_VALIDATION=1 to disable this validation.
qt.qpa.fonts: Populating font family aliases took 145 ms. Replace uses of missing font family "Times" with one that exists to avoid this cost. 

However, I found that it became harder to make a better fit. I mean, it could derive a quite correct and good result by merely click the "RV Auto fit" in the old ver. of Exostriker, but now, it's pretty difficult to fit it well with the same dataset. I don't know if this is a problem...

So, these are a few problems after installing the latest version of Exostriker on iMac(Mac Ventura 13.5.2, intel core i7).

Looking forward to your reply! Thanks!

Best,
Yingyi

@3fon3fonov
Copy link
Owner Author

Hi @Astrocyy,

First, let us open another "issue" :) There I will answer your questions :)

This thread I will close since I think the BIC/AIC and DOF values are now correct.

@3fon3fonov
Copy link
Owner Author

3fon3fonov commented Dec 7, 2023

Hi again @Astrocyy,

Regardng your first problem I have open an issue here:

#126

For the second one:

However, I found that it became harder to make a better fit. I mean, it could derive a quite correct and good result by merely click the "RV Auto fit" in the old ver. of Exo-Striker, but now, it's pretty difficult to fit it well with the same dataset. I don't know if this is a problem...

The problem was that I have made the SciPyOp the default optimizer, because @MatheusJCastro and I have made many improvements in the Exo-Striker's RV-model speed. However, I see that the SciPyOp is not always converging well. One has to play a bit with the SciPyOp options (Model Opt. --> SciPy opt., --> and e.g., Nelder-Mead options), but I see this could be cumbersome for the user. I will work in the direction to somehow make the SciPyOp to choose the appropriate options automatically, if that is possible at all.

OK, I am rolling back the default Fortran optimizer. Please git pull and do your tests again. Keep in mind, however, that the Fortran optimization code cannot accept limits and priors, whereas SciPyOp can (albite being the slower option). You can always swap between SciPyOp and the default RVmod optimizer in (Model Opt. --> RV model).

Let me know if you still have problems,
Trifon

@Astrocyy
Copy link

Astrocyy commented Dec 7, 2023

Hi Trifon,

I saw the #126 last night. Thank you so much for your quick reply!

The major problem now is that the whole exostriker always crashed suddenly and need reopen after I just started to fix the RV data. And everytime I open the exostriker, these warnings occurs:

0.00s - Debugger warning: It seems that frozen modules are being used, which may
0.00s - make the debugger miss breakpoints. Please pass -Xfrozen_modules=off
0.00s - to python to disable frozen modules.
0.00s - Note: Debugging will proceed. Set PYDEVD_DISABLE_FILE_VALIDATION=1 to disable this validation.
qt.qpa.fonts: Populating font family aliases took 145 ms. Replace uses of missing font family "Times" with one that exists to avoid this cost. 

Then I tried exostriker -debug, it showed the same warnings.

io:~ yingyicao$ exostriker -debug
0.00s - Debugger warning: It seems that frozen modules are being used, which may
0.00s - make the debugger miss breakpoints. Please pass -Xfrozen_modules=off
0.00s - to python to disable frozen modules.
0.00s - Note: Debugging will proceed. Set PYDEVD_DISABLE_FILE_VALIDATION=1 to disable this validation.
qt.qpa.fonts: Populating font family aliases took 145 ms. Replace uses of missing font family "Times" with one that exists to avoid this cost. 
jupyter-client==8.6.0
ipykernel==6.27.1
PyQt5==5.15.10
qtconsole==5.5.1
matplotlib==3.8.2
emcee==3.1.4
numpy==1.26.2
scipy==1.11.4
wotan==1.10
jupyter==1.0.0
celerite==0.4.2
pathos==0.3.1
ttvfast==0.3.0
You are running a development version of the Exo-Striker (ver. 0.86). 
              
This version is almost full, but there are still some parts of the tool, which are in a 'Work in progress' state. Please, 'git pull' regularly to be up to date with the newest version.

Here you can get some more information from the tool's workflow, stdout/strerr, and piped results.

I don't know if there is something wrong with the Python(3.11.7 ver.)..
It would be so nice of you to give me some advice to fix it! Thank you so much!

Best,
Yingyi

@3fon3fonov
Copy link
Owner Author

Hi @Astrocyy ,

Let us move here:
#126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants