Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unit conversions on properties #564

Open
dokempf opened this issue Feb 13, 2025 · 0 comments
Open

Handle unit conversions on properties #564

dokempf opened this issue Feb 13, 2025 · 0 comments
Labels
python-api Related to the new Helios++ Python API sustainable h++ Part of the sustainable HELIOS++ project

Comments

@dokempf
Copy link
Collaborator

dokempf commented Feb 13, 2025

We currently have the situation that we allow a user to specify certain properties in degrees, but internally convert them to radians. This leads to the confusing situation that setting and getting a property directly after one another will not yield the same result:

from helios.scanner import ScannerSettings
settings = ScannerSettings()
settings.rotation_start_angle = 180
print(settings.rotation_start_angle)

This will print 3.14... instead of 180. In a CLI world this never mattered. In a Python API it is rather inconvenient.

@dokempf dokempf added python-api Related to the new Helios++ Python API sustainable h++ Part of the sustainable HELIOS++ project labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python-api Related to the new Helios++ Python API sustainable h++ Part of the sustainable HELIOS++ project
Projects
None yet
Development

No branches or pull requests

1 participant