Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile support for 3d simulation suspended. #87

Closed
watcherdm opened this issue Sep 3, 2023 · 3 comments
Closed

Mobile support for 3d simulation suspended. #87

watcherdm opened this issue Sep 3, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@watcherdm
Copy link
Contributor

Currently, suspending the 3D simulation doesn't allow this library to work on mobile as it still tries to load the WebGL context and the WASM code. It would be ideal if this library provided a delicate fallback: "the world doesn't support fancy 3D things; let's just generate random numbers and return the expected result shape."

@frankieali frankieali self-assigned this Jan 21, 2024
@frankieali frankieali added the enhancement New feature or request label Jan 21, 2024
@frankieali
Copy link
Contributor

I made a first pass at adding this feature in version 1.0.11 that was just released. Still needs some testing.

@watcherdm
Copy link
Contributor Author

So, I updated the package to the version you recommended and now the dice just work on my iPhone. Unsure if what you implemented fixed it or if some update from apple fixed it lol. Anyway, thanks for the work, 3d dice rolling on my mobile phone is LIT!

@frankieali
Copy link
Contributor

Hey. Great to hear that the dice are rolling now. I bumped the module dependencies for BabylonJS, the underlying 3D rendering engine. I guess that may have fixed some webGL rendering issue. I think shadows were also causing some rendering issue that were also fixed. Either way, glad things are working. I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants