From 976f13aada5581730f81f1b691d7bebb0aecff0b Mon Sep 17 00:00:00 2001 From: Aparna Hegde Date: Tue, 20 Oct 2020 10:11:27 -0400 Subject: [PATCH 01/11] Update for video support --- dev-docs/bidders/33across.md | 142 ++++++++++++++++++++++++++++++++++- 1 file changed, 141 insertions(+), 1 deletion(-) diff --git a/dev-docs/bidders/33across.md b/dev-docs/bidders/33across.md index 6d80a41759..0a9fc120bc 100644 --- a/dev-docs/bidders/33across.md +++ b/dev-docs/bidders/33across.md @@ -4,6 +4,7 @@ title: 33Across description: Prebid 33Across Bidder Adapter hide: true biddercode: 33across +media_types: banner, video gdpr_supported: true schain_supported: true usp_supported: true @@ -16,4 +17,143 @@ usp_supported: true | Name | Scope | Description | Example | Type | |-------------|----------|--------------------------------------------------------------------------------------------------------------------------------|------------|----------| | `siteId` | required | Publisher GUID from 33Across | `'examplePub123'` | `string` | -| `productId` | required | 33Across Product ID that the Publisher has registered for (use `'siab'` for standard supply and `'inview'` for renderer) | `'siab'` | `string` | +| `productId` | required | 33Across Product ID that the Publisher has registered for (use `'siab'` for standard supply, `'inview'` for renderer, `'instream'` for instream video) | `'siab'` | `string` | + +### Ad Unit Setup for Banner +```javascript +var adUnits = [ +{ + code: '33across-hb-ad-123456-1', // ad slot HTML element ID + mediaTypes: { + banner: { + sizes: [ + [300, 250], + [728, 90] + ] + } + } + bids: [{ + bidder: '33across', + params: { + siteId: 'cxBE0qjUir6iopaKkGJozW', // required + productId: 'siab|inview' // required + } + }] +} +``` + +### Ad Unit Setup for Video: Outstream +```javascript +var adUnits = [ +{ + code: '33across-hb-ad-123456-1', // ad slot HTML element ID + mediaTypes: { + video: { // We recommend setting the following video params + // in Ad Unit rather than bidder params as per Prebid 4.0 recommendation. + playerSize: [300, 250], // required + context: 'outstream', // required + mimes: ['video/mp4','video/x-flv'], // required + placement: 2, // optional defaults to 2 for outstream + api: [ 1, 2 ], // optional + protocols: [ 2, 3 ], // optional + skippable: true, // optional + minduration: 5, // optional + maxduration: 30, // optional + playbackmethod: [1,3], // optional + battr: [ 13, 14 ], // optional + linearity: 1, // optional + placement: 2, // optional + minbitrate: 10, // optional + maxbitrate: 10 // optional + } + }, + bids: [{ + bidder: '33across', + params: { + siteId: 'cxBE0qjUir6iopaKkGJozW', + productId: 'siab' + } + }], + ... +} +``` + +### Ad Unit Setup for Video: Instream +```javascript +var adUnits = [ +{ + code: '33across-hb-ad-123456-1', // ad slot HTML element ID + mediaTypes: { + video: { // We recommend setting the following video params + // in Ad Unit rather than bidder params as per Prebid 4.0 recommendation. + playerSize: [300, 250], // required + context: 'outstream', // required + mimes: ['video/mp4','video/x-flv'], // required + placement: 2, // optional, defaults to 1 for outstream + startdelay: 0, // optional, defaults to 0 for instream + api: [ 1, 2 ], // optional + protocols: [ 2, 3 ], // optional + skippable: true, // optional + minduration: 5, // optional + maxduration: 30, // optional + playbackmethod: [1,3], // optional + battr: [ 13, 14 ], // optional + linearity: 1, // optional + placement: 2, // optional + minbitrate: 10, // optional + maxbitrate: 10 // optional + } + }, + bids: [{ + bidder: '33across', + params: { + siteId: 'cxBE0qjUir6iopaKkGJozW', + productId: 'siab' + } + }], + ... +} +``` + +### Ad Unit Setup for Mult-format: Banner, Video (Outstream only) +```javascript +var adUnits = [ +{ + code: '33across-hb-ad-123456-1', // ad slot HTML element ID + mediaTypes: { + banner: { + sizes: [ + [300, 250], + [728, 90] + ] + }, + video: { // We recommend setting the following video params + // in Ad Unit rather than bidder params as per Prebid 4.0 recommendation. + playerSize: [300, 250], // required + context: 'outstream', // required + mimes: ['video/mp4','video/x-flv'], // required + placement: 2, // optional defaults to 2 for outstream + api: [ 1, 2 ], // optional + protocols: [ 2, 3 ], // optional + skippable: true, // optional + minduration: 5, // optional + maxduration: 30, // optional + playbackmethod: [1,3], // optional + battr: [ 13, 14 ], // optional + linearity: 1, // optional + placement: 2, // optional + minbitrate: 10, // optional + maxbitrate: 10 // optional + } + }, + bids: [{ + bidder: '33across', + params: { + siteId: 'cxBE0qjUir6iopaKkGJozW', + productId: 'siab' + } + }], + ... +} +``` + From e8de9ec7d366238a9e0b1c4a560e53fb43828605 Mon Sep 17 00:00:00 2001 From: Aparna Hegde Date: Tue, 20 Oct 2020 12:00:26 -0400 Subject: [PATCH 02/11] fixes to video params --- dev-docs/bidders/33across.md | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/dev-docs/bidders/33across.md b/dev-docs/bidders/33across.md index 0a9fc120bc..642bf960fe 100644 --- a/dev-docs/bidders/33across.md +++ b/dev-docs/bidders/33across.md @@ -35,8 +35,8 @@ var adUnits = [ bids: [{ bidder: '33across', params: { - siteId: 'cxBE0qjUir6iopaKkGJozW', // required - productId: 'siab|inview' // required + siteId: 'examplePub123', // required + productId: 'siab|inview' // required } }] } @@ -53,7 +53,7 @@ var adUnits = [ playerSize: [300, 250], // required context: 'outstream', // required mimes: ['video/mp4','video/x-flv'], // required - placement: 2, // optional defaults to 2 for outstream + placement: 2, // optional, defaults to 2 when context = outstream api: [ 1, 2 ], // optional protocols: [ 2, 3 ], // optional skippable: true, // optional @@ -62,7 +62,6 @@ var adUnits = [ playbackmethod: [1,3], // optional battr: [ 13, 14 ], // optional linearity: 1, // optional - placement: 2, // optional minbitrate: 10, // optional maxbitrate: 10 // optional } @@ -70,7 +69,7 @@ var adUnits = [ bids: [{ bidder: '33across', params: { - siteId: 'cxBE0qjUir6iopaKkGJozW', + siteId: 'examplePub123', productId: 'siab' } }], @@ -89,7 +88,7 @@ var adUnits = [ playerSize: [300, 250], // required context: 'outstream', // required mimes: ['video/mp4','video/x-flv'], // required - placement: 2, // optional, defaults to 1 for outstream + placement: 1, // optional, defaults to 1 when context = instream startdelay: 0, // optional, defaults to 0 for instream api: [ 1, 2 ], // optional protocols: [ 2, 3 ], // optional @@ -99,7 +98,6 @@ var adUnits = [ playbackmethod: [1,3], // optional battr: [ 13, 14 ], // optional linearity: 1, // optional - placement: 2, // optional minbitrate: 10, // optional maxbitrate: 10 // optional } @@ -107,7 +105,7 @@ var adUnits = [ bids: [{ bidder: '33across', params: { - siteId: 'cxBE0qjUir6iopaKkGJozW', + siteId: 'examplePub123', productId: 'siab' } }], @@ -132,7 +130,7 @@ var adUnits = [ playerSize: [300, 250], // required context: 'outstream', // required mimes: ['video/mp4','video/x-flv'], // required - placement: 2, // optional defaults to 2 for outstream + placement: 2, // optional, defaults to 2 when context = outstream api: [ 1, 2 ], // optional protocols: [ 2, 3 ], // optional skippable: true, // optional @@ -141,7 +139,6 @@ var adUnits = [ playbackmethod: [1,3], // optional battr: [ 13, 14 ], // optional linearity: 1, // optional - placement: 2, // optional minbitrate: 10, // optional maxbitrate: 10 // optional } @@ -149,7 +146,7 @@ var adUnits = [ bids: [{ bidder: '33across', params: { - siteId: 'cxBE0qjUir6iopaKkGJozW', + siteId: 'examplePub123', productId: 'siab' } }], From 0500e85cdf46311948d724b580ba544d3ef757de Mon Sep 17 00:00:00 2001 From: Aparna Hegde Date: Tue, 20 Oct 2020 12:01:37 -0400 Subject: [PATCH 03/11] fixed context --- dev-docs/bidders/33across.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev-docs/bidders/33across.md b/dev-docs/bidders/33across.md index 642bf960fe..9af418bb29 100644 --- a/dev-docs/bidders/33across.md +++ b/dev-docs/bidders/33across.md @@ -86,7 +86,7 @@ var adUnits = [ video: { // We recommend setting the following video params // in Ad Unit rather than bidder params as per Prebid 4.0 recommendation. playerSize: [300, 250], // required - context: 'outstream', // required + context: 'intstream', // required mimes: ['video/mp4','video/x-flv'], // required placement: 1, // optional, defaults to 1 when context = instream startdelay: 0, // optional, defaults to 0 for instream From c7a9356d996b4b10372306c5f1e4fcaa287ef6fd Mon Sep 17 00:00:00 2001 From: Aparna Hegde Date: Tue, 20 Oct 2020 12:07:26 -0400 Subject: [PATCH 04/11] fixed instream params --- dev-docs/bidders/33across.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dev-docs/bidders/33across.md b/dev-docs/bidders/33across.md index 9af418bb29..e85d47b93a 100644 --- a/dev-docs/bidders/33across.md +++ b/dev-docs/bidders/33across.md @@ -89,7 +89,7 @@ var adUnits = [ context: 'intstream', // required mimes: ['video/mp4','video/x-flv'], // required placement: 1, // optional, defaults to 1 when context = instream - startdelay: 0, // optional, defaults to 0 for instream + startdelay: 0, // optional, defaults to 0 when context = instream api: [ 1, 2 ], // optional protocols: [ 2, 3 ], // optional skippable: true, // optional @@ -106,7 +106,7 @@ var adUnits = [ bidder: '33across', params: { siteId: 'examplePub123', - productId: 'siab' + productId: 'instream' } }], ... From bda725bd3809aa738eb167fdd59b83ddd827b4c5 Mon Sep 17 00:00:00 2001 From: Aparna Hegde Date: Tue, 20 Oct 2020 12:08:16 -0400 Subject: [PATCH 05/11] fix for multi-format --- dev-docs/bidders/33across.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev-docs/bidders/33across.md b/dev-docs/bidders/33across.md index e85d47b93a..0e20c9abc5 100644 --- a/dev-docs/bidders/33across.md +++ b/dev-docs/bidders/33across.md @@ -113,7 +113,7 @@ var adUnits = [ } ``` -### Ad Unit Setup for Mult-format: Banner, Video (Outstream only) +### Ad Unit Setup for Mult-format: Banner, Video (Outstream) ```javascript var adUnits = [ { From c4053926dfcb39d557a1760fe8d6b53de1cd52d8 Mon Sep 17 00:00:00 2001 From: Aparna Hegde Date: Tue, 20 Oct 2020 12:13:45 -0400 Subject: [PATCH 06/11] Fixed Ad Unit titles --- dev-docs/bidders/33across.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/dev-docs/bidders/33across.md b/dev-docs/bidders/33across.md index 0e20c9abc5..ee859dab48 100644 --- a/dev-docs/bidders/33across.md +++ b/dev-docs/bidders/33across.md @@ -42,7 +42,7 @@ var adUnits = [ } ``` -### Ad Unit Setup for Video: Outstream +### Ad Unit Setup for Outstream Video ```javascript var adUnits = [ { @@ -56,7 +56,7 @@ var adUnits = [ placement: 2, // optional, defaults to 2 when context = outstream api: [ 1, 2 ], // optional protocols: [ 2, 3 ], // optional - skippable: true, // optional + skip: 0, // optional minduration: 5, // optional maxduration: 30, // optional playbackmethod: [1,3], // optional @@ -77,7 +77,7 @@ var adUnits = [ } ``` -### Ad Unit Setup for Video: Instream +### Ad Unit Setup for Instream Video ```javascript var adUnits = [ { @@ -92,7 +92,7 @@ var adUnits = [ startdelay: 0, // optional, defaults to 0 when context = instream api: [ 1, 2 ], // optional protocols: [ 2, 3 ], // optional - skippable: true, // optional + skip: 0, // optional minduration: 5, // optional maxduration: 30, // optional playbackmethod: [1,3], // optional @@ -133,7 +133,7 @@ var adUnits = [ placement: 2, // optional, defaults to 2 when context = outstream api: [ 1, 2 ], // optional protocols: [ 2, 3 ], // optional - skippable: true, // optional + skip: 0, // optional minduration: 5, // optional maxduration: 30, // optional playbackmethod: [1,3], // optional From bbcae80d5ef9f4b6d4cff0c805ebcbf386115cbd Mon Sep 17 00:00:00 2001 From: Aparna Hegde Date: Tue, 20 Oct 2020 12:17:57 -0400 Subject: [PATCH 07/11] protocols is required --- dev-docs/bidders/33across.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/dev-docs/bidders/33across.md b/dev-docs/bidders/33across.md index ee859dab48..a332509ab4 100644 --- a/dev-docs/bidders/33across.md +++ b/dev-docs/bidders/33across.md @@ -53,9 +53,9 @@ var adUnits = [ playerSize: [300, 250], // required context: 'outstream', // required mimes: ['video/mp4','video/x-flv'], // required + protocols: [ 2, 3 ], // required, set at least 1 value in Array placement: 2, // optional, defaults to 2 when context = outstream api: [ 1, 2 ], // optional - protocols: [ 2, 3 ], // optional skip: 0, // optional minduration: 5, // optional maxduration: 30, // optional @@ -86,8 +86,9 @@ var adUnits = [ video: { // We recommend setting the following video params // in Ad Unit rather than bidder params as per Prebid 4.0 recommendation. playerSize: [300, 250], // required - context: 'intstream', // required + context: 'instream', // required mimes: ['video/mp4','video/x-flv'], // required + protocols: [ 2, 3 ], // required, set at least 1 value in Array placement: 1, // optional, defaults to 1 when context = instream startdelay: 0, // optional, defaults to 0 when context = instream api: [ 1, 2 ], // optional @@ -130,6 +131,7 @@ var adUnits = [ playerSize: [300, 250], // required context: 'outstream', // required mimes: ['video/mp4','video/x-flv'], // required + protocols: [ 2, 3 ], // required, set at least 1 value in Array placement: 2, // optional, defaults to 2 when context = outstream api: [ 1, 2 ], // optional protocols: [ 2, 3 ], // optional From 10a7de7d86177cac2f9d32cae9d4c2b308134774 Mon Sep 17 00:00:00 2001 From: Aparna Hegde Date: Tue, 20 Oct 2020 12:20:22 -0400 Subject: [PATCH 08/11] typo fix --- dev-docs/bidders/33across.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev-docs/bidders/33across.md b/dev-docs/bidders/33across.md index a332509ab4..2810c76018 100644 --- a/dev-docs/bidders/33across.md +++ b/dev-docs/bidders/33across.md @@ -114,7 +114,7 @@ var adUnits = [ } ``` -### Ad Unit Setup for Mult-format: Banner, Video (Outstream) +### Ad Unit Setup for Multi-format: Banner, Video (Outstream) ```javascript var adUnits = [ { From 24adeaa6822bbaa9d34b4940ee47e3fdda029ea3 Mon Sep 17 00:00:00 2001 From: Aparna Hegde Date: Tue, 20 Oct 2020 12:26:58 -0400 Subject: [PATCH 09/11] Added required bidder param --- dev-docs/bidders/33across.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/dev-docs/bidders/33across.md b/dev-docs/bidders/33across.md index 2810c76018..e1b946579f 100644 --- a/dev-docs/bidders/33across.md +++ b/dev-docs/bidders/33across.md @@ -69,8 +69,8 @@ var adUnits = [ bids: [{ bidder: '33across', params: { - siteId: 'examplePub123', - productId: 'siab' + siteId: 'examplePub123', // required + productId: 'siab' // required } }], ... @@ -106,8 +106,8 @@ var adUnits = [ bids: [{ bidder: '33across', params: { - siteId: 'examplePub123', - productId: 'instream' + siteId: 'examplePub123', // required + productId: 'instream' // required } }], ... @@ -148,8 +148,8 @@ var adUnits = [ bids: [{ bidder: '33across', params: { - siteId: 'examplePub123', - productId: 'siab' + siteId: 'examplePub123', // required + productId: 'siab' // required } }], ... From ae4be7695c6e907550877f49b6187cb7ef486d7a Mon Sep 17 00:00:00 2001 From: Aparna Hegde Date: Tue, 20 Oct 2020 12:28:25 -0400 Subject: [PATCH 10/11] removed duplicate video params --- dev-docs/bidders/33across.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/dev-docs/bidders/33across.md b/dev-docs/bidders/33across.md index e1b946579f..6a52c97b80 100644 --- a/dev-docs/bidders/33across.md +++ b/dev-docs/bidders/33across.md @@ -92,7 +92,6 @@ var adUnits = [ placement: 1, // optional, defaults to 1 when context = instream startdelay: 0, // optional, defaults to 0 when context = instream api: [ 1, 2 ], // optional - protocols: [ 2, 3 ], // optional skip: 0, // optional minduration: 5, // optional maxduration: 30, // optional @@ -134,7 +133,6 @@ var adUnits = [ protocols: [ 2, 3 ], // required, set at least 1 value in Array placement: 2, // optional, defaults to 2 when context = outstream api: [ 1, 2 ], // optional - protocols: [ 2, 3 ], // optional skip: 0, // optional minduration: 5, // optional maxduration: 30, // optional From 4781ed1337b4d08046291b863af39f2ba1cbb33e Mon Sep 17 00:00:00 2001 From: Aparna Hegde Date: Tue, 20 Oct 2020 12:58:16 -0400 Subject: [PATCH 11/11] formatting edits --- dev-docs/bidders/33across.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dev-docs/bidders/33across.md b/dev-docs/bidders/33across.md index 6a52c97b80..a156b00f54 100644 --- a/dev-docs/bidders/33across.md +++ b/dev-docs/bidders/33across.md @@ -17,7 +17,7 @@ usp_supported: true | Name | Scope | Description | Example | Type | |-------------|----------|--------------------------------------------------------------------------------------------------------------------------------|------------|----------| | `siteId` | required | Publisher GUID from 33Across | `'examplePub123'` | `string` | -| `productId` | required | 33Across Product ID that the Publisher has registered for (use `'siab'` for standard supply, `'inview'` for renderer, `'instream'` for instream video) | `'siab'` | `string` | +| `productId` | required | 33Across Product ID that the Publisher has registered for (use `'siab'` for Banner or Outstream Video , `'inview'` for Adhesion, `'instream'` for Instream Video) | `'siab'` | `string` | ### Ad Unit Setup for Banner ```javascript @@ -53,7 +53,7 @@ var adUnits = [ playerSize: [300, 250], // required context: 'outstream', // required mimes: ['video/mp4','video/x-flv'], // required - protocols: [ 2, 3 ], // required, set at least 1 value in Array + protocols: [ 2, 3 ], // required, set at least 1 value in array placement: 2, // optional, defaults to 2 when context = outstream api: [ 1, 2 ], // optional skip: 0, // optional @@ -88,7 +88,7 @@ var adUnits = [ playerSize: [300, 250], // required context: 'instream', // required mimes: ['video/mp4','video/x-flv'], // required - protocols: [ 2, 3 ], // required, set at least 1 value in Array + protocols: [ 2, 3 ], // required, set at least 1 value in array placement: 1, // optional, defaults to 1 when context = instream startdelay: 0, // optional, defaults to 0 when context = instream api: [ 1, 2 ], // optional @@ -130,7 +130,7 @@ var adUnits = [ playerSize: [300, 250], // required context: 'outstream', // required mimes: ['video/mp4','video/x-flv'], // required - protocols: [ 2, 3 ], // required, set at least 1 value in Array + protocols: [ 2, 3 ], // required, set at least 1 value in array placement: 2, // optional, defaults to 2 when context = outstream api: [ 1, 2 ], // optional skip: 0, // optional