Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add key --show-logs #10

Closed
dekhtyarev opened this issue Aug 16, 2018 · 3 comments
Closed

add key --show-logs #10

dekhtyarev opened this issue Aug 16, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request P1 Normal priority

Comments

@dekhtyarev
Copy link
Collaborator

Вывод логов

Доступна только для Job (а точнее для Non-parallel Jobs)

После завершения работы пода, созданного джобой, выведет его логи на экран.
Завершением работы пода считается переход из состояния Running в состояниe Succeeded/Failed/Unknown
Рантайм режим временно не доступен из-за бага: kubernetes-client/python#199

k8s-handle deploy --section <section_name> --config <config-name> --show-logs

При необходимости указать кол-во строк

--tail-lines <tail-lines> (по умолчанию выведет все логи с момента создания пода)

PS Для Parallel Jobs можно пока не реализовывать. Запросов на них ещё не было

@rvadim rvadim added the enhancement New feature or request label Aug 16, 2018
@dekhtyarev dekhtyarev added P1 Normal priority P0 Need to fix ASAP and removed P1 Normal priority labels Aug 20, 2018
@rvadim rvadim self-assigned this Aug 24, 2018
@rvadim
Copy link
Collaborator

rvadim commented Aug 24, 2018

Why its P0? It's just logging improvement.

@dekhtyarev
Copy link
Collaborator Author

dekhtyarev commented Aug 24, 2018

Some pipelines will be broken, who used this feature in internal k8s-handle release:

$ k8s-handle deploy --section run-at-ci --sync-mode --show-logs
usage: k8s-handle [-h] {deploy,destroy} ...
k8s-handle: error: unrecognized arguments: --show-logs
ERROR: Job failed: exit code 1

But this may be P1.. I change

@dekhtyarev dekhtyarev added P1 Normal priority and removed P0 Need to fix ASAP labels Aug 24, 2018
@dekhtyarev
Copy link
Collaborator Author

Don't forget 2+ containers in POD support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 Normal priority
Projects
None yet
Development

No branches or pull requests

2 participants