Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the community standard defer-hydration attribute #14

Closed
zachleat opened this issue Nov 12, 2022 · 5 comments
Closed

Support the community standard defer-hydration attribute #14

zachleat opened this issue Nov 12, 2022 · 5 comments
Labels
enhancement New feature or request
Milestone
<is-land> v3.0.0

Comments

@zachleat
Copy link
Member

zachleat commented Nov 12, 2022 •
edited
Loading

This will allow us to avoid the node renaming mechanism for lazy custom element hydration, which will be much faster.

via: #13 (comment)
Proposal: webcomponents-cg/community-protocols#15

Currently this requires component authors to add support for this attribute to their component code. is-land takes the task of removing the attribute when the island is ready.
@zachleat zachleat added the enhancement New feature or request label Nov 12, 2022
@zachleat zachleat added this to the <is-land> Next Version milestone Nov 14, 2022
@zachleat
Copy link
Member Author

Fixed by fafe092

@zachleat
Copy link
Member Author

Sample component implementation here: https://github.com/11ty/is-land/blob/fafe092b551d2f741203e9e86858b71df4f0c76d/lib/chocolate-web-component.js

@zachleat zachleat changed the title Watch for/foster/adopt defer-hydration attribute Support the community standard defer-hydration attribute Nov 14, 2022
@zachleat
Copy link
Member Author

cc @dgp1130 this is shipping with is-land v3.0.0!

cross-linking to #13 (comment)

@zachleat zachleat mentioned this issue Nov 14, 2022
Closed
@dgp1130
Copy link

dgp1130 commented Nov 14, 2022

Awesome! Was planning to make a PR / file an issue about this after our discussion, but looks like you beat me to it. 😁

@zachleat
Copy link
Member Author

@dgp1130 Nerd sniped 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
<is-land> v3.0.0
Development

No branches or pull requests
2 participants
@zachleat @dgp1130