Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated version of nodejs is required #157

Closed
1 task done
aaronjorbin opened this issue Mar 15, 2024 · 0 comments · Fixed by #160
Closed
1 task done

Outdated version of nodejs is required #157

aaronjorbin opened this issue Mar 15, 2024 · 0 comments · Fixed by #160
Assignees
@Sidsector9
Labels
type:bug Something isn't working.
Milestone
1.3.0

Comments

@aaronjorbin
Copy link

Describe the bug

The current nvmrc file requires node 16 is end of life. Would fixing this be within the purview of stable support?

Steps to Reproduce

Using a system that has nvm detection,

  1. git clone https://github.com/10up/convert-to-blocks.git
  2. cd convert-to-blocks

Note:
Found '/path/convert-to-blocks/.nvmrc' with version
Now using node v16.20.2 (npm v8.19.4)

Screenshots, screen recording, code snippet

No response

Environment information

Followed the instructions at https://github.com/nvm-sh/nvm?tab=readme-ov-file#calling-nvm-use-automatically-in-a-directory-with-a-nvmrc-file to support autodetecting nvmrc files

WordPress information

n/a

Code of Conduct

  • I agree to follow this project's Code of Conduct
@aaronjorbin aaronjorbin added the type:bug Something isn't working. label Mar 15, 2024
@jeffpaul jeffpaul added this to the 1.3.0 milestone Mar 18, 2024
@jeffpaul jeffpaul moved this from Incoming to To Do in Open Source Practice Mar 18, 2024
@Sidsector9 Sidsector9 moved this from To Do to In Progress in Open Source Practice Mar 29, 2024
@Sidsector9 Sidsector9 mentioned this issue Mar 29, 2024
Merged
4 tasks
@Sidsector9 Sidsector9 moved this from In Progress to In Review in Open Source Practice Mar 29, 2024
@github-project-automation github-project-automation bot moved this from In Review to Merged in Open Source Practice Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sidsector9 Sidsector9

Labels
type:bug Something isn't working.
Projects
Open Source Practice
Archived in project
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

upkeep/157: upgrade node to v20 10up/convert-to-blocks
3 participants
@aaronjorbin @jeffpaul @Sidsector9