Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Status Report is showing a message count from ElasticPress.io when not using ElasticPress.io #3375

Closed
1 task done
JakePT opened this issue Mar 7, 2023 · 0 comments · Fixed by #3376
Closed
1 task done
Assignees
Labels
bug Something isn't working
Milestone

Comments

@JakePT
Copy link
Contributor

JakePT commented Mar 7, 2023

Describe the bug

The Status Report page is supposed to show messages from an EPIO endpoint, and count indicating the number of messages is displayed next to the admin menu item. The problem is that a message count is being showing for non-ElasticPress.io users, as the error response when checking for messages is being counted as messages.

The ElasticPressIo::get_endpoint_messages() method needs to be updated to not bother making the request is Utils\is_epio() is false, and to ignore non-200 responses.

Steps to Reproduce

  1. Connect ElasticPress to self-hosted Elasticsearch.
  2. Go to ElasticPress > Status Report. No messages will be displayed, but a count will be shown next to the admin menu item.

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress and ElasticPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@JakePT JakePT added the bug Something isn't working label Mar 7, 2023
@JakePT JakePT added this to the 4.5.0 milestone Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants