Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent sending requests to ES if orderby is set to post__in #3272

Closed
1 task done
burhandodhy opened this issue Jan 25, 2023 · 0 comments · Fixed by #3273
Closed
1 task done

Prevent sending requests to ES if orderby is set to post__in #3272

burhandodhy opened this issue Jan 25, 2023 · 0 comments · Fixed by #3273
Assignees
@felipeelia
Labels
enhancement
Milestone
4.5.0

Comments

@burhandodhy
Copy link
Contributor

Is your enhancement related to a problem? Please describe.

Elasticsearch only allows asc or desc for the sorting, and if the WordPress query has orderby to post__in; the ES query ends with the error No mapping found for [post__in] in order to sort on.  

As the query never ends successfully, to prevent this error, the suggested solution is to never send the request to ES if the orderby is set to post__in. 

Related issue #773

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipeelia felipeelia

Labels
enhancement
Projects
None yet
Milestone
4.5.0
Development

Successfully merging a pull request may close this issue.

Prevent using the EP if query has unsuported orderby 10up/ElasticPress
2 participants
@felipeelia @burhandodhy