Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the Users Indexable to ElasticPress Labs #3180

Closed
1 task done
felipeelia opened this issue Dec 5, 2022 · 3 comments · Fixed by #3334
Closed
1 task done

Move the Users Indexable to ElasticPress Labs #3180

felipeelia opened this issue Dec 5, 2022 · 3 comments · Fixed by #3334
Assignees
Labels
enhancement module:users Issues related to the Users Indexable / Feature.
Milestone

Comments

@felipeelia
Copy link
Member

Is your enhancement related to a problem? Please describe.

As stated in ElaticPress 4.4.0 changelog, we will be moving the Users Indexable to ElasticPress Labs. In order to make that happen, we will need to move the indexable to EP Labs before we release EP 5.0.0 (and those two versions will have to coexist for a while, using the EPLabs version if both are available.)

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@nickchomey
Copy link
Contributor

I'm not sure what the right place is to ask this, but this seems as good as any.

Is there an issue or discussion somewhere that goes into some more detail about why Users is being moved to Labs, and Terms and Comments are being hidden? I'm not at all opposed to this, but just want to have a better understanding of the rationale and plans for EP going forward - particularly for what 5.0 will bring.

Also, does this affect Features and Indexables at all? I make use of those for indexing, syncing and querying custom tables with ElasticPress.

Thanks!

@felipeelia
Copy link
Member Author

Hey @nickchomey, here are some answers for you:

  • The Features and Indexables classes are not going to change. I've introduced a visibility concept in Conditionally load the Users feature #3334 but that won't change anything for custom features.
  • The reason behind moving the Users feature to EP Labs is security: as we can not be responsible for everybody's setups and being users a so sensitive feature, we understand it is best placed in a more "Experimental" plugin.
  • Regarding Terms and Comments, people often enable those without a real need (especially "Terms" tends to confuse people with "Do I need this to sync a post term?" which is not the case at all.)

@felipeelia felipeelia assigned burhandodhy and unassigned felipeelia Feb 24, 2023
@nickchomey
Copy link
Contributor

Thanks very much! That makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement module:users Issues related to the Users Indexable / Feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants