-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error handling #251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@onein528 What on earth did you do b506654 for?
It breaks the search system. |
WHAT? No I didn't break any feature. Look at it carefully. I created some duplicated attribution by main fetching. So I deleted them. |
Ahh. Sorry. |
You can see nicer error page! Just try it out. |
BTW @onein528 Please use strings from now on. |
OK! Thanks. I also will. |
@onein528 I'd set a custom title bar element like in SignIn so the profile/home/explore/tabview etc. are hidden. |
Almost of all exceptions are not recoverable. But network disconnection exception titled 'An error occurred while sending the request' is recoverable and general exception error. I think the app should provide page as it is to restart immediately whenever network is back for user by clicking 'Try Again'. Yes design issue I know but this could be functional issue. |
But we still have a 'refresh' button. @onein528 |
Let it be clear. clicking 'Try Again', that left-side navigation view will be back? |
Yep. But only if the error is resolved after clicking 'Try Again' ofc. @onein528 |
Good. I'll try to do that. |
Why did you reset label from high pri to medium pri? |
Why so high priority? @onein528 |
High: Must be Committed. |
@DeveloperWOW64 can you see UserControls/Overview/RepositoryOverview.xaml and it's inside Stargizer count badge and it's converter? It is way better than previous converter as helper methods. What do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
⏱️ Before you start
None
📄 Description
As the title
💭 Motivation and Context
Applied on:
Clean up:
📸 Assets (if appropriate):