[Hub Generated] Review request for Microsoft.KeyVault to add version …

…stable/2019-09-01 (Azure#8458) * Added SoftDeleteRetentionInDays, CustomizedRecoverable and recoverableDays (Azure#8457) Co-authored-by: gdlxm <40441617+gdlxm@users.noreply.github.com> Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com> * Added `enableRbacAuthorization` property to Key Vault management plane (Azure#8468) * Add default=90 to softDeleteRetentionInDays (Azure#8476) * Add default=90 to softDeleteRetentionInDays Add default=90 to softDeleteRetentionInDays * Remove default softDeleteRetentionInDays when patching Remove default softDeleteRetentionInDays when patching. Co-authored-by: gdlxm <40441617+gdlxm@users.noreply.github.com> Co-authored-by: iscai-msft <43154838+iscai-msft@users.noreply.github.com> Co-authored-by: Fernando Colombo <msfcolombo@users.noreply.github.com>
00Kai0 · Oct 12, 2020 · ec25719 · ec25719
1 parent d472eb2
commit ec25719
Show file tree

Hide file tree

Showing 5 changed files with 34 additions and 11 deletions.
diff --git a/CODEOWNERS b/CODEOWNERS
@@ -34,7 +34,7 @@
 /specification/insights/ @gucalder
 /specification/intune/ @vrmurthy01
 /specification/iothub/ @rkmanda
-/specification/keyvault/ @schaabs
+/specification/keyvault/ @schaabs @heaths
 /specification/logic/ @pankajsn @tonytang-microsoft-com
 /specification/machinelearning/ @nonstatic2014
 /specification/machinelearningcompute/ @shutchings

diff --git a/.../resource-manager/Microsoft.KeyVault/preview/2018-02-14-preview/examples/deleteVault.json b/.../resource-manager/Microsoft.KeyVault/preview/2018-02-14-preview/examples/deleteVault.json
@@ -7,8 +7,10 @@
   },
   "responses": {
     "200": {
-      "headers": {},
-      "body": ""
+      "headers": {}
+    },
+    "204": {
+      "headers": {}
     }
   }
 }
diff --git a/...rce-manager/Microsoft.KeyVault/preview/2018-02-14-preview/examples/purgeDeletedVault.json b/...rce-manager/Microsoft.KeyVault/preview/2018-02-14-preview/examples/purgeDeletedVault.json
@@ -6,11 +6,7 @@
     "api-version": "2018-02-14-preview"
   },
   "responses": {
-    "200": {
-      "body": ""
-    },
-    "202": {
-      "body": ""
-    }
+    "200": {},
+    "202": {}
   }
 }
diff --git a/...ion/keyvault/resource-manager/Microsoft.KeyVault/preview/2018-02-14-preview/keyvault.json b/...ion/keyvault/resource-manager/Microsoft.KeyVault/preview/2018-02-14-preview/keyvault.json
@@ -174,6 +174,9 @@
         "responses": {
           "200": {
             "description": "OK Response."
+          },
+          "204": {
+            "description": "No Content."
           }
         },
         "x-ms-examples": {

diff --git a/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/keyvault.json b/specification/keyvault/resource-manager/Microsoft.KeyVault/stable/2019-09-01/keyvault.json
@@ -1122,7 +1122,19 @@
         },
         "enableSoftDelete": {
           "type": "boolean",
-          "description": "Property to specify whether the 'soft delete' functionality is enabled for this key vault. If omitted, assume true as default value. Once set to true, cannot be reverted to false."
+          "default": true,
+          "description": "Property to specify whether the 'soft delete' functionality is enabled for this key vault. If it's not set to any value(true or false) when creating new key vault, it will be set to true by default. Once it's been set to true value, it can NOT be reverted to false."
+        },
+        "softDeleteRetentionInDays": {
+          "type": "integer",
+          "format": "int32",
+          "default": 90,
+          "description": "softDelete data retention days. It accepts >=7 and <=90."
+        },
+        "enableRbacAuthorization": {
+          "type": "boolean",
+          "default": false,
+          "description": "Property that controls how data actions are authorized. When true, the key vault will use Role Based Access Control (RBAC) for authorization of data actions, and the access policies specified in vault properties will be  ignored (warning: this is a preview feature). When false, the key vault will use the access policies specified in vault properties, and any policy stored on Azure Resource Manager will be ignored. If null or not specified, the vault is created with the default value of false. Note that management actions are always authorized with RBAC."
         },
         "createMode": {
           "type": "string",
@@ -1191,7 +1203,17 @@
         },
         "enableSoftDelete": {
           "type": "boolean",
-          "description": "Property to specify whether the 'soft delete' functionality is enabled for this key vault. If omitted, assume true as default value. Once set to true, cannot be reverted to false."
+          "default": false,
+          "description": "Property to specify whether the 'soft delete' functionality is enabled for this key vault. If omitted, assume false as default value when patching an existing vault. Once set to true, cannot be reverted to false."
+        },
+        "softDeleteRetentionInDays": {
+          "type": "integer",
+          "format": "int32",
+          "description": "softDelete data retention days. It accepts >=7 and <=90."
+        },
+        "enableRbacAuthorization": {
+          "type": "boolean",
+          "description": "Property that controls how data actions are authorized. When true, the key vault will use Role Based Access Control (RBAC) for authorization of data actions, and the access policies specified in vault properties will be  ignored (warning: this is a preview feature). When false, the key vault will use the access policies specified in vault properties, and any policy stored on Azure Resource Manager will be ignored. If null or not specified, the value of this property will not change."
         },
         "createMode": {
           "type": "string",