Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add components checking #682

Merged
merged 2 commits into from
Dec 25, 2024
Merged

add components checking #682

merged 2 commits into from
Dec 25, 2024

Conversation

tyowk
Copy link
Contributor

@tyowk tyowk commented Dec 23, 2024

Description

implemented changes to ensure that messages containing only components (without any content, attachments or embeds) can still be sent.

this changes also applies to functions such as $sendMessage, $channelSendMessage, $sendDM, and other similar functions responsible for sending messages that support components parser

Type of change

Please check options that describe your Pull Request:

  • Bug fix (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

  • My code follows the style guidelines of this project
  • Any dependent changes have been merged and published in downstream modules

@tyowk
Copy link
Contributor Author

tyowk commented Dec 25, 2024

fr

Copy link
Member

@Faf4a Faf4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@Faf4a Faf4a merged commit bff74c4 into aoijs:v6 Dec 25, 2024
@Faf4a Faf4a added this to the 6.10.0 milestone Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants