Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macro resolution #681

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Fix macro resolution #681

merged 1 commit into from
Dec 25, 2024

Conversation

Cyberghxst
Copy link
Contributor

Description

This pull request fixes an accidentally introduced bug in macros feature.
It basically were replacing every "#word", "# word" to an empty string, that wasn't intended to happen.
Now it replaces the possible macros in the code only if theres ones cached and checks if the current macro exists, if they don't skips to the next match.

Type of change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

  • My code follows the style guidelines of this project
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@Faf4a Faf4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@Faf4a Faf4a merged commit 13fa104 into aoijs:v6 Dec 25, 2024
@Faf4a Faf4a added this to the 6.10.0 milestone Dec 25, 2024
@Cyberghxst Cyberghxst deleted the macros-fix branch December 27, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants